Giter Site home page Giter Site logo

Comments (5)

swiesend avatar swiesend commented on August 27, 2024 1

As @purejava pointed out: only skipping the check leads to other problems, as both dbus services (secret-service and gnome-keyring) are tightly integrated in the current implementation (see: InternalUnsupportedGuiltRiddenInterface). I think it would be possible to make it work with some refactoring, but currently I do not find the time for that. Although it would be a nice to have for the 2.x.x branch. @shocklateboy92 you are more than welcome to make it happen.

Depending on what you need and want to achieve I think you are better off with @purejava's keepassxc-proxy-access and providing a small implementation of your own like https://github.com/purejava/keepassxc-cryptomator/blob/develop/src/main/java/org/purejava/integrations/keychain/KeePassXCAccess.java. Is that right @purejava?

from secret-service.

shocklateboy92 avatar shocklateboy92 commented on August 27, 2024

It looks like you'd just need to move that check into InternalUnsupportedGuiltRiddenInterface.java.

@swiesend : If I create a PR to make that change, will you accept it?

from secret-service.

purejava avatar purejava commented on August 27, 2024

What exactly are you trying to achieve? 🙂

SimpleCollection was designed to work with gnome keyring and therefore needs this check.

KeePassXC does have a secret service feature, that attaches KeePassXC with the secret service API on your linux machine and allows applications to store passwords in KeePassXC via secret service instead of the gnome keyring, as secret service would normally do.

KeePassXC launches it's own daemon called "keepassxc" that provides it's own secret service interfaces, that is the middle layer between any application using a password backend and the password backend itself. KeePassXC's own secret service interfaces differ massively from the ones, gnome keyring does provide.

SimpleCollection does use the secret service API provided by gnome keyring.

from secret-service.

shocklateboy92 avatar shocklateboy92 commented on August 27, 2024

Hi @purejava, @swiesend, thank you for your responses!

What exactly are you trying to achieve? slightly_smiling_face

In short: to get rid of gnome-keyring from my machine 🙂

Since kwallet started implementing org.freedesktop.secrets interface, I've gotten pretty close - almost every app that required gnome-keyring now works with kwallet.
The holdout is Microsoft Identity Broker, which is required for corporate device enrollment/management. It crashes on startup if gnome-keyring is not running because it uses this library for credential storage.

Since I work for the company, I'm working on reaching out to the teams that own it to let me make a patch. However, when I get there I think a small patch to update the version of library they're already using would be an easier sell than building a new abstraction layer between 2 libraries 😏

However, if you think messing with InternalUnsupportedGuiltRiddenInterface is a much bigger task than I seem to think it is, then please let me know.

Also do let me know if you think there's a better way of achieving my goal of using kdewallet for everything.

PS: I don't really use keepassxc, I just brought it up because this change might be useful for people that do. 😸

from secret-service.

purejava avatar purejava commented on August 27, 2024

Also do let me know if you think there's a better way of achieving my goal of using kdewallet for everything.

There is also kdewallet, which does not implement the Secret Service API, but accesses KWallet over it's D-Bus interfaces.

from secret-service.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.