Comments (5)
As @purejava pointed out: only skipping the check leads to other problems, as both dbus services (secret-service
and gnome-keyring
) are tightly integrated in the current implementation (see: InternalUnsupportedGuiltRiddenInterface
). I think it would be possible to make it work with some refactoring, but currently I do not find the time for that. Although it would be a nice to have for the 2.x.x
branch. @shocklateboy92 you are more than welcome to make it happen.
Depending on what you need and want to achieve I think you are better off with @purejava's keepassxc-proxy-access
and providing a small implementation of your own like https://github.com/purejava/keepassxc-cryptomator/blob/develop/src/main/java/org/purejava/integrations/keychain/KeePassXCAccess.java. Is that right @purejava?
from secret-service.
It looks like you'd just need to move that check into InternalUnsupportedGuiltRiddenInterface.java
.
@swiesend : If I create a PR to make that change, will you accept it?
from secret-service.
What exactly are you trying to achieve? 🙂
SimpleCollection
was designed to work with gnome keyring and therefore needs this check.
KeePassXC does have a secret service feature, that attaches KeePassXC with the secret service API on your linux machine and allows applications to store passwords in KeePassXC via secret service instead of the gnome keyring, as secret service would normally do.
KeePassXC launches it's own daemon called "keepassxc" that provides it's own secret service interfaces, that is the middle layer between any application using a password backend and the password backend itself. KeePassXC's own secret service interfaces differ massively from the ones, gnome keyring does provide.
SimpleCollection
does use the secret service API provided by gnome keyring.
from secret-service.
Hi @purejava, @swiesend, thank you for your responses!
What exactly are you trying to achieve? slightly_smiling_face
In short: to get rid of gnome-keyring from my machine 🙂
Since kwallet started implementing org.freedesktop.secrets
interface, I've gotten pretty close - almost every app that required gnome-keyring now works with kwallet.
The holdout is Microsoft Identity Broker, which is required for corporate device enrollment/management. It crashes on startup if gnome-keyring is not running because it uses this library for credential storage.
Since I work for the company, I'm working on reaching out to the teams that own it to let me make a patch. However, when I get there I think a small patch to update the version of library they're already using would be an easier sell than building a new abstraction layer between 2 libraries 😏
However, if you think messing with InternalUnsupportedGuiltRiddenInterface is a much bigger task than I seem to think it is, then please let me know.
Also do let me know if you think there's a better way of achieving my goal of using kdewallet for everything.
PS: I don't really use keepassxc, I just brought it up because this change might be useful for people that do. 😸
from secret-service.
Also do let me know if you think there's a better way of achieving my goal of using kdewallet for everything.
There is also kdewallet
, which does not implement the Secret Service API, but accesses KWallet over it's D-Bus interfaces.
from secret-service.
Related Issues (20)
- Please update to dbus-java 3.2.3 HOT 2
- [feature-request] interface re-design to get more flexibility HOT 4
- DBusConnection - broken pipe HOT 1
- DBusConnection - RejectedExecutionException HOT 4
- what to pass to SimpleCollection constructor? HOT 2
- Log thrown exceptions instead of exception cause HOT 1
- Logger NPE in MessageHandler.send HOT 1
- Closing `SimpleCollection` does not stop `DBusConnection` HOT 2
- SimpleCollection.isAvailable checks for wrong service HOT 5
- Does Lock / Unlock method do anything for a non-default SimpleCollection? HOT 2
- Do we have some benchmarks available for this library? HOT 4
- AutoClose disconnects from the DBus HOT 1
- Update to `dbus-java` 4.x HOT 10
- Bump hkdf to 2.0.0
- avoid split packages HOT 2
- GNOME keyring is not triggered to show an unlock prompt on application autostart HOT 1
- Secret Service not found in Docker Container HOT 4
- Unlocking Secrets before retrieving them HOT 6
- `ExceptionInInitializerError` thrown when calling SimpleCollection.isAvailable() HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from secret-service.