swxk19/ped

ped's Issues

No character limit on data field.

Description
No character limit is imposed for adding fields, can potentially clog up UI.

Potential Improvement

Impose a hard character limit, or truncate with ellipses

Clicking on both lists highlights items in both lists

Description

To navigate the list with up/down arrow keys, they first have to be clicked. Clicking both lists results in items of both lists being highlighted, which makes it unclear which list is currently selected.

Steps to reproduce

1. Click on the elderly list
2. Click on the volunteer list

Expected Behaviour

Selecting another list should unselect the previous list

Phone number doesn't allow country code

Description

There may be instances where the person only holds a foreign phone number, and the special character "+62" would not be accepted.

UG: Ambiguous phrasing for "Undo the previous command"

Description

In the "Shortcuts" section, the description for CTRL+Z says "Undo the previous command". I was given the impression that I was able to restore the program to its previous state. E.g I was under the impression that I could call undo after running add_elderly ... and it would remove the elderly that was just added.

Potential improvement

Change the phrasing to better describe that CTRL+Z only pertains to the text in the command box.

Example command for adding volunteer is invalid

Description

The example command given for add_volunteer is not valid. This appears in both the application and the "Command Summary" section of the UG.

Steps to reproduce

1. Type and run add_volunteer (invalid command) to see the example command given
2. Copy paste the example command add_volunteer n/John Doe p/98765432 e/[email protected] a/311, Clementi Ave 2, #02-25 ic/S1234567A bd/2002-12-01 re/NORTH mt/CPR BASIC t/new t/undergradStudent dr/2023-05-11,2023-05-12
3. Error given "Medical qualification must be a skill, followed by a skill-level. format: [Skill], [Level]" (There is a missing comma in mt/CPR BASIC)

Auto-Complete: No auto-complete suggestion for list command

Description

There are no auto-complete suggestions for the command list.
While the pair / unpaired flags are optional for the command, it might be useful to suggest them to the user, so they are aware.
Similar to how optional fields for adding an elderly are also suggested, even if they are not necessary.

Incorrect red highlighting for valid command

Description

The red-highlighting for incorrect commands prematurely highlights a valid, but incomplete command as red.

Steps to reproduce

1. Type in the command add_elderly n, without running it.
   2.The command is highlighted red

Expected behaviour

It should behave similar to when you type in the command add_elderly n/ abcxyz i. The command box is able to correctly detect that the command is still incomplete, and suggests the continuation of "i" as "ic/" correctly.

Auto-Complete: Duplicate suggestions appearing

Description:

Auto-complete suggests multiple of the same prefixes

Steps to reproduce:

1. Paste in this command without running it: add_volunteer n/Doe bd/1998-02-01 ic/S8457677H p/98765432 e/[email protected] a/block 123 re/WEST t/graduate mt/CPR, BASIC d
2. The auto-complete for dr/ appears twice

Expected Behaviour:

The auto-complete suggestion for dr/ prefix only appears once

Name with special characters not allowed

Description

There are some instances where names can contain special characters such as "Ramesh s/o Muthu", which would not be accepted by the add commands.

Unclear description of functionality of Arrow Up/Down in UG

For Arrow Up/Down in the "Shortcuts" section of the UG, I was unclear of what was meant by "Navigate to the previous item on the list".
I was unaware that the 2 lists could be selected by clicking them (which I discovered through random clicking around), in order to navigate with the arrow keys.

Possible Improvement: Perhaps it could be mentioned somewhere in the UG that you can click on the lists to navigate them with the arrow keys

Multiple inputs of the same prefix allowed

Description
Typing the same prefix multiple times is accepted as a valid command.

Steps to reproduce

1. Type in add_volunteer n/Doe bd/1998-02-01 ic/S8457677H p/98765432 e/[email protected] a/block 123 re/WEST t/graduate mt/CPR, BASIC re/north (notice that "re/" appears twice)
2. The volunteer is successfully added with region as "north"

Expected behaviour

It should be an invalid command