sylabs/fuzzctl

CLI for Fuzzball, enabling management of high performance compute workflows.

fuzzctl's Issues

Persist Configuration

We need the ability to persist configuration, such as endpoints authentication tokens. Add code to do that.

Discover Auth Parameters During Login

Currently, there are a number of parameters that are hard-coded in loginCmd:

https://github.com/sylabs/compute-cli/blob/f7deb67f2584382b64e024d46a370284b352242e/internal/app/cli/login.go#L19-L47

What we probably want to happen is that the user/administrator can configure a single URL, and the rest of these parameters are discovered from a well-known endpoint based on that URL. The OAuth 2.0 Authorization Server Metadata spec covers some, but not all of these parameters, so won't be suitable on its own. The back end should host a discovery endpoint that will act as a source for this info.

The parameters that will need to be discovered are (at this moment):

• OAuth ClientID
• oauth2.Endpoint, which itself contains the AuthURL and TokenURL values. These can/should be discovered from a /.well-known/oauth-authorization-server endpoint.
• The listenAddr and authPath in the auth package

Validate Fields in YAML

The CLI doesn't currently detect unknown fields in the workflow YAML. For example, this is accepted even though foo isn't a valid key:

version: 0.1
foo: bar
workflow:
  name: wf
  jobs:
    jobA:
      image: library://alpine:latest
      command: ["date"]

We should validate keys somehow (and maybe we could provide a validate command in the CLI?)

Mage Versioning Enhancements

A few Mage versioning enhancements requested in #32 (review):

• Would be nice to have the magefile.go report a warning if a tag object is not found, as someone is, at some point going to tag without -a and wonder why everything is unknown.
• Would be nice to have the git commit set even if there is no tag and version is unknown.

Request Additional OAuth Scope(s)

Define OAuth scope(s) that will be used for authorization, and include them in the auth.NewInteractiveTokenSource() call:

https://github.com/sylabs/compute-cli/blob/f7deb67f2584382b64e024d46a370284b352242e/internal/app/cli/login.go#L24-L34

As an example of a public APIs defined scopes, GitHub has good documentation of theirs (ref).

Logout not working

dave@piran~/S/G/fuzzctl> fuzzctl logout
dave@piran~/S/G/fuzzctl> fuzzctl list
NAME        ID                        STATUS
HelloWorld  5e8b3abc66507b6825c2e789  COMPLETED
dave@piran~/S/G/fuzzctl> fuzzctl create examples/helloworld.yaml
INFO[0000] Created workflow: Name: HelloWorld, ID: 5e8b46228e2fc1f370e3f135 

Token still exists at ~/.config/fuzzball/config.yaml

Create different structs different types of queries.

Currently the compute client package uses structs that mimic the types of the GraphQL API, this results in issues when trying to form a query with stucts of the form:

type Job struct {
    Requires []Job
}

Due to some infinite recursion.

A better approach involves using structs that are query specific in order reflect the interesting data the query and properly declare the depth of search.