Comments (12)
I'm closing the issue as #1129 has been merged. Thanks to everyone for your advices and reviews ❤️
from recipes-contrib.
We accept recipes for any packages available on Packagist (we do have plenty on non-bundles already).
Replacing an existing file is not an option as it would make debugging/upgrading/... much harder. We should find another way. Maybe the new runtime component can help here?
Generating files is one of the things a recipe can do, so I don't any issue here.
from recipes-contrib.
@OskarStark that is the same amount of changes as telling the user to extend Bref's modified Kernel.
from recipes-contrib.
Ok I thought it would need more adjustments 👍🏻
from recipes-contrib.
Thanks everyone for the input ! @ker0x I think we should start simple
- copy-from-recipe for the serverless.yaml
- add .serverless in gitignore
- add a post-install.txt to explain what to do with the kernel
Once done, we could see what more can be done with the Kernel.
What do you think ?
from recipes-contrib.
@fabpot thank you for the answer!
Replacing an existing file is not an option as it would make debugging/upgrading/... much harder. We should find another way. Maybe the new runtime component can help here?
Nyholm is working hard on that, the runtime component could be useful in some ways, but AFAIK not directly for this problem.
On Lambda, logs & cache need to be moved elsewhere (because the filesystem is read-only except for /tmp
). The only way to do that is by editing Kernel.php
(unless there's another way?).
Worst case scenario: we ask the user to do the change manually, which isn't the end of the world. But I'd love to know if there's an alternative that could be automated.
from recipes-contrib.
What about adding a ServerlessKernel.php file next to the Kernel and tell the user to change one line in index.php ?
from recipes-contrib.
What about adding a ServerlessKernel.php file next to the Kernel and tell the user to change one line in index.php ?
IMHO it's just moving the manual action to another place.
The current documented way with the Kernel is below and moving to index.php would be similar.
// src/Kernel.php
namespace App;
+ use Bref\SymfonyBridge\BrefKernel;
use Symfony\Bundle\FrameworkBundle\Kernel\MicroKernelTrait;
use Symfony\Component\Config\Loader\LoaderInterface;
use Symfony\Component\Config\Resource\FileResource;
use Symfony\Component\DependencyInjection\ContainerBuilder;
-use Symfony\Component\HttpKernel\Kernel as BaseKernel;
use Symfony\Component\Routing\RouteCollectionBuilder;
- class Kernel extends BaseKernel
+ class Kernel extends BrefKernel
{
// ...
from recipes-contrib.
@t-richard sounds good, though I wouldn't put any documentation file in the project: readers should be following the documentation already so we can explain the last step there.
from recipes-contrib.
@t-richard it sounds good to me too, I will start to work on it this week probably !
@mnapoli At first the post-install.txt
file will only show a link to the documentation (which will need to be updated though). We can always improve it later
from recipes-contrib.
@ker0x I'd rather not have a documentation file inserted into the project, that doesn't correspond to any practice found in other open-source projects. Users are already following the documentation, we can instruct them on what to do inside the documentation.
from recipes-contrib.
Thank you @ker0x!
from recipes-contrib.
Related Issues (20)
- Bug in automatic merging process? HOT 1
- Post-install for Flysystem v2 gives wrong instructions
- [Sentry Bundle] Clarify config when using monolog HOT 2
- 404 page HOT 1
- SKELETON_VERSION compatibility HOT 1
- IN SF 4.4 Argument 1 passed to FOS\OAuthServerBundle\Entity\ClientManager::__construct() must be an instance of Doctrine\Common\Persistence\ObjectManager HOT 4
- [Idea][Feature request] Allow to setup base project for GHActions / CI verification HOT 2
- Fatal error for mongodb-odm-bundle on Symfony 6 (prod) HOT 1
- recipes-contrib check for PHP 7.4 failing expectedly, preventing merging HOT 3
- Failure on recipe update of friendsofsymfony/ckeditor-bundle
- My library only supports up to 5.4 not symfony6 , and my pull requests always fail when symfony6 checks automatically HOT 5
- New version for sonata page bundle HOT 1
- Process Issue: Contributions are Often Stalled HOT 8
- Rerun failed generation due GitHub was down HOT 1
- The php_codesniffer recipe report errors with the default Symfony installation HOT 1
- PHPStan install instructions reference the wrong name for the included config file
- EUPL as an authorized license HOT 10
- Allow recipes for packages with other type than "symfony-bundle" HOT 3
- Travis build fails for packages with virtual dependency HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from recipes-contrib.