Process Issue: Contributions are Often Stalled

[amacrobert]

Process Issue: Contributions are Often Stalled

[fabpot]

And then, I've just reviewed 2 PRs randomly, and clearly, both of them should not be merged: #1433 (review) and #1430 (review)

So, I think merging automatically is not a good idea after all. It means we need more volunteers to help.

[fabpot]

I will close this issue now as it's not actionable.
I've spent a lot of time reviewing/merging/closing PRs and we're now in a good state.
Reviewing PRs can also be done by non-core-team members and we definitely need help here.

[fabpot]

The only possibility I can see here is to auto-merge any contribution for which tests pass and without any requests for changes. Afterall, that's the goal of the contrib recipe repository: be as open as possible.

[vvasiloi]

A lot of tests fail because the package doesn't support one of the Symfony versions the tests run against.
This issue alone creates a lot of stale PRs.
Another one is that some packages support outdated versions of Symfony and/or PHP, which also make the tests fail.
I think we should make them a little bit more tolerant.

[amacrobert]

So, I think merging automatically is not a good idea after all. It means we need more volunteers to help.

Some thoughts:

1. Could we auto-merge PRs after 90 days? They would have to pass (required) checks and not have a pending change request. This might actually motivate core members to review more often, since there's a time limit on when their review holds power.
2. In either case, if the solution required more volunteers, I think there should be clear instructions on how to become a volunteer.

[VincentLanglet]

This might actually motivate core members to review more often

This won't add any motivation, just unnecessary pressure or merge PR which shouldn't be merged.
I would say volunteers are running out of time, not motivation.

[CJayHe]

My pr hasn't passed in months with no feedback, and it's seriously affecting my plans to release new features.
#1444

[fabpot]

@CJayHe I've just reviewed your PR.