Adding extra parameters to company get request

[synergitech]

Adding extra parameters to company get request

[willpower232]

Thanks for your interest.

I don't think there is a way of specifying it currently but if you're able to make a PR to add in an optional array of extra fields to the get function which gets merged into the array which contains language then we can get that released for you

creditsafe-connect/src/Service/CompanyService.php

Lines 43 to 45 in 65a29f1

	public function get(string $id, string $reportLang = 'en') : Company
	{
	return new Company($this->client, $this->client->get('companies/'.$id, ['language' => $reportLang]));

[DaanGeurts]

Hi Will,

I found this PR #8
But it's not merged due to linting and formatting...

[willpower232]

Ah so it is, well they clearly have no intent on completing it.

The change I described above is only two lines worth of change so would be a much simpler and future proof solution if you have some time to work on it?

[DaanGeurts]

Yes it could be a simple addition but there is more to it as you can read from the documentation. There is an extra endpoint to fetch all the available reason codes per country.
If you agree with a array merge of params and not adding the endpoint etc I'm more then happy to create a pull request

[willpower232]

Of course, if you want to grab and maybe improve src/Service/ReportCustomData.php from that PR as part of yours then that is probably a complete solution.

[DaanGeurts]

Are you happy with the structure and code of the PR as I can copy that for my PR?

[willpower232]

if the linter is happy with you then it should be fine, that PR seemed to change a lot of code that wasn't related to the original issue and, whilst probably necessary at some point, really confused the issue 😅

[DaanGeurts]

Hi Will,
i've created a new pull request based of the pull request mentioned here.
Let me know!

[willpower232]

Looks great to me, I've released it so feel free to close if you have no more issues on this topic