synergitech/creditsafe-connect

creditsafe-connect's Issues

Adding extra parameters to company get request

Hi,
thanks for all the hard work!
I have a question, when getting a German report one should provide
/companies/{id}?customData=de_reason_code::{reasonCode} the reason code for legal purposes.
Documentation
using companies()->get($companyId, $language), is there any method to provide this customData property?

Token Handling

Release Date Pending: Limit on Invalid Calls on Authenticate Endpoint

During mid Q1, we will be introducing a limit of 5 invalid requests per 120 seconds to the Connect Authenticate Endpoint. Any more requests during this period will cause "Too many Requests" with status code 429.

This functionality is applicable on the authenticate endpoint and is to avoid invalid credentials-based requests flooding our internal systems which could lead to a potential degradation of service. So long as correct and valid credentials are submitted, the introduction of this limit will not impact typical calls to our API.

Release Date Pending: WAF based Rate Limiting on Authenticate Endpoint

We will also be implementing a WAF limit of 300 requests in a rolling 5-minute period made to the authenticate endpoint. Any more requests during the said period will cause "Too many Requests" with status code 429 (ref 429 Too Many Requests - HTTP | MDN (mozilla.org)). We strongly advise all integrations to utilise a token management system where tokens are persisted and reused for the whole life of the token, which currently sits at 60 minutes, and to avoid sending an authenticate request before every other API endpoint request.

Our current use case for this library doesn't involve many requests so it is unlikely we will trigger these limits however this library is not designed for long term token storage so that may need to become a feature in the future.

install package with guzzle ^7.xx

In my case it is mandatory to use this package together with guzzlehttp/guzzle "^7.xx". However, the installation is not done because version "^6.3" is required.

Issue with page size, but it's set at 1?

Getting this strange bug when I search by name. any idea's?

(See below for details)

Bad request: Invalid value '[14]' for query parameter page. Invalid number 14 expected number between 1 and 13 vendor/synergitech/creditsafe-connect/src/Client.php Line:175

The code i have is

$creditSafeClient = new \SynergiTech\Creditsafe\Client([
		'username' => env('CREDIT_SAFE_USERNAME'),
		'password' => env('CREDIT_SAFE_PASSWORD')
]);
					
$searchParams = ['countries' => 'GB', 'name' => 'Test'];
$creditSafeResults = $creditSafeClient->companies()->search($searchParams);
$creditSafeResults->setPageSize(1);


if ($creditSafeResults->valid()) {
	foreach ($creditSafeResults as $result) {
		$accounts = $result->get();
	}
	$returnArray['code'] = 200;
	$returnArray['accounts'] = $accounts;
} else {
	$returnArray['code'] = 200;
	$returnArray['message'] = 'No results found';
}

Index positions is not guaranteed to exist

creditsafe-connect/src/Models/Company/Director.php

Line 37 in 4975326

}, $this->directorDetails['positions']);