Don't use advice-add or defadvice

[systemcrafters]

Don't use advice-add or defadvice

[jeffbowman]

We are avoiding fset in this case because it is difficult (impossible?) to reverse. Should a user prefer the long answers (yes vs y), this configuration would make it very difficult to go back to using yes-or-no-p (see #54)

In this case, if you use fset and then in the users config.el try to undo it like this: (fset 'y-or-n-p 'yes-or-no-p) it doesn't work like you expect. Instead you get this error in *Messages*:

Symbol’s chain of function indirections contains a loop: y-or-n-p

See the comment with this code, it describes how to reverse this decision by removing the advice.

I'm open to other solutions that allow a user to reverse this decision.

[jeffbowman]

Closing, since there is no discussion since April.