Giter Site home page Giter Site logo

Comments (10)

angrybacon avatar angrybacon commented on August 19, 2024 5

I think there's a thin line between making a base pool of sensible and cautious defaults vs. making a new configuration (with or without a wizard to set it up) like what Doom and Spacemacs might provide to the community already. I think this kind of question will come back in various forms and the README could use some section to clarify what we want in this repository vs. what should be left to the user to implement themselves the way they see fit.

Not that I'm very much against the feature, but I think there are a lot of ways to go about it and that should be a clear indicator that crafters would rather implement their leader key in their preferred way 🤓

from crafted-emacs.

jeffbowman avatar jeffbowman commented on August 19, 2024 3

I prefer standard Emacs keys. So, I don't use evil mode or other modes similar to that, and I'm not terribly interested in a leader-key configuration. I think a module with this setup would make sense (I can choose not to use it, others can choose to use it).

from crafted-emacs.

erikLundstedt avatar erikLundstedt commented on August 19, 2024

one big upside to this would be that it makes it a bit easier for us coming from spacemacs or doom to move to rational without having to re-learn everything, assuming its done right

from crafted-emacs.

terxw avatar terxw commented on August 19, 2024

I am using general definer from Emacs from scratch e.g. rune/leader-key-def and I even added it to doom emacs (and also rational-emacs) to sync my keybindings across different configuration (with the goal to remove conflicting ones form default doom emacs config)

from crafted-emacs.

Gavinok avatar Gavinok commented on August 19, 2024

In my opinion there isn't really much benefit here. Evil already provides leader functionality. If we wanted to emulate some doom bindings maybe someone could make a module for it.

from crafted-emacs.

theophilusx avatar theophilusx commented on August 19, 2024

I'm also not convinced re: a leader key module or adding modules to make transition from other setups easier (guidelines to assist in migration could be something added to documentation).

The main reason I don't like the idea is I think it will miss an important opportunity. One of the very interesting aspects of rational eamcs is the use of vertico and embark. In particular, embark brings a different 'style' of UI which I find very interesting (i.e. the inversion of UI from action -> thing to thing -> action). IMO this inversion makes the UI model of spacemacs/doom style hierarchical menus of actions on a leader key with which key etc less valuable/useful. To really get this benefit, it is important to have a UI which encourages people to select the 'thing' and then the action. Making it easy for people to clone the UI styule they are familiar with will work against this.

Note that I'm not against general.el - I think it is actually are really interesting and powerful module and it could be something rational emacs may want to use/include. I would just prefer it not be used to create a less functional clone of spacemaces/doom.

If we did decide to add a leader key configuration, I would consider adding one which creates bindings that focus on selecting 'things' rather than one which focuses on selecting actions.

from crafted-emacs.

erikLundstedt avatar erikLundstedt commented on August 19, 2024

In my opinion there isn't really much benefit here. Evil already provides leader functionality. If we wanted to emulate some doom bindings maybe someone could make a module for it.

Evil already provides leader functionality

how do i do that?
i found a package (evil-leader) that does it but it doesnt seem to do anything much differently to general.el
is there a way to do it with just evil?

from crafted-emacs.

erikLundstedt avatar erikLundstedt commented on August 19, 2024

I think there's a thin line between making a base pool of sensible and cautious defaults vs. making a new configuration (with or without a wizard to set it up) like what Doom and Spacemacs might provide to the community already. I think this kind of question will come back in various forms and the README could use some section to clarify what we want in this repository vs. what should be left to the user to implement themselves the way they see fit.

Not that I'm very much against the feature, but I think there are a lot of ways to go about it and that should be a clear indicator that crafters would rather implement their leader key in their preferred way nerd_face

I am not talking about forcing anyone to use it, nor am i sugesting trying to replace all of dooms keybinds
what i am talking about is to add the ability for module maintainers to easily add leader-keybinds for us who actually want it

this would still only be loaded on user request(with a variable) or if the required packages are installed
this is what we already do with

(with-eval-after-load 'evil
  (define-key vertico-map (kbd "C-j") 'vertico-next)
  (define-key vertico-map (kbd "C-k") 'vertico-previous)
  (define-key vertico-map (kbd "M-h") 'vertico-directory-up))

so what the developer would do is something like

(with-eval-after-load 'evil-leader
   (evil-leader/set-key "key" 'some-command-or-action)
)

or equivalent with general.el

from crafted-emacs.

jeffbowman avatar jeffbowman commented on August 19, 2024

There has not been much further discussion on this, and there doesn't seem to be much support for it. Can this issue be closed?

from crafted-emacs.

jeffbowman avatar jeffbowman commented on August 19, 2024

Closing as there has been no further discussion.

from crafted-emacs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.