Giter Site home page Giter Site logo

chord-collection's People

Contributors

t-vk avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

Forkers

johannydls

chord-collection's Issues

Where and how did you get the data?

I saw your message in an issue at https://github.com/tombatossals/chords-db. I think, that you have got the data from the chord-collection.com website. You have written about some script and I would like to get ukulele chords data from chord-collection.com in similar way. Can you put the script there, please? ๐Ÿ˜„ Thanks

EDIT: Sorry, I didn't read the message properly. You have got it really from chordsdatabase.com. There aren't any uke chords.

Many fingerings appear incorrect/impossible to achieve?

Hi,

Firstly - awesome job on collecting this data!

Sadly, It appears that many of the fingerings are way out? some examples:

 "Am13/C": [{
    "positions": ["x", "3", "5", "2", "5", "2"],
    "fingerings": [
      ["0", "2", "3", "1", "4", "4"]
    ]
  }],

Should be:

 "Am13/C": [{
    "positions": ["x", "3", "5", "2", "5", "2"],
    "fingerings": [
      ["0", "2", "3", "1", "4", "1"] // no way you can play it as a 4!? ๐Ÿ˜ฑ 
    ]
  }],

And

  "Ab7#9/F#": [{
    "positions": ["2", "3", "4", "4", "4", "4"],
    "fingerings": [
      ["1", "2", "3", "3", "3", "4"]
    ]
  }],

Should be:

  "Ab7#9/F#": [{
    "positions": ["2", "3", "4", "4", "4", "4"],
    "fingerings": [
      ["1", "2", "3", "3", "3", "3"] // no need for 4?
    ]
  }],

etc etc. from what I can tell, this effects a rather large number of chords... is there any chance you can update this awesome collection using whatever magical method you used originally - please? (I understand, you got these from jguitar.com? that is what I am comparing these fingerings too, also...)

Would be much appreciated! ๐Ÿ™

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.