t0ri-make-school-coursework/personalhomepage

MS FEW 1.1 Personal Homepage Project

personalhomepage's Issues

Not sure this is a heading...

https://github.com/t0ri/personalhomepage/blob/64224b991150c7007462e794b254bd618c30e8cd/index.html#L29

I'm not sure this is a heading. This could be the name of the a chapter in a book but I'm not sure if that's what's going on here. Make this a div. You can style the text to look the same.

Don't use a an H1-6 when you want the text to be large and bold. Use a heading when you are declaring the title of a section or other important info.

?

https://github.com/t0ri/personalhomepage/blob/64224b991150c7007462e794b254bd618c30e8cd/index.html#L143

Set the font family on the body

https://github.com/t0ri/personalhomepage/blob/64224b991150c7007462e794b254bd618c30e8cd/css/styles.css#L9

Setting the font family on the body will make sure all elements use this base font. This is easier to fix and easier to change and edit, leads to DRY code. You should be doing it.

A inside heading

https://github.com/t0ri/personalhomepage/blob/64224b991150c7007462e794b254bd618c30e8cd/index.html#L13

The Anchor <a> should go inside the <h3> always. The a is an inline element, and the h1-6 is a block, an inline element always goes inside a block.

Good use of sections, and...

https://github.com/t0ri/personalhomepage/blob/64224b991150c7007462e794b254bd618c30e8cd/index.html#L12

Great use of sections. Each sections is a section, remember a section should probably have a heading.

Also, don't use sections to hang styles or as targets for JavaScript. Use a div for these purposes. You can wrap your section in a div, or wrap the contents of the section I a div. Put the id and class names on the div.

http://html5doctor.com/avoiding-common-html5-mistakes/

Footer is probably <footer>

https://github.com/t0ri/personalhomepage/blob/64224b991150c7007462e794b254bd618c30e8cd/index.html#L177

This footer doesn't really sound like secondary content. It's really a footer and we have a tag for that. You could wrap it as a section, not seems like a section that's part of the whole, rather than peripheral content.

Love your home page

I really like your home page. It's clean and simple. It's got nice bold presentation. I think this is working well. I have a few suggestions.

The menu feels kinds cramped and pushed up into the corner. Why not move this down and to the right a little. Also the type is Times. This is default font. I like the font in the message on the right. Roboto is a great font use it for everything.

The menu also displays as white on gray with a blue underline. This looks a little weird. Get rid of the underline it just makes the text look busy. I feel like the text could use a little more contrast or the font size could be bumped up a tiny Bit to make it read a little better.

The About looks great. I like the layout. The text is a little dense. Consider setting the line height to 1.5em or something. Just play with the line height and choose a number that makes it read good.

The contact page is nice. The Heading feels a little overbearing. Consider Changing the color to lower the contrast, or use a light font. Look at the faces for Roboto here:

https://fonts.google.com/specimen/Roboto

Notice the Regular, Light, and Thin. Consider using these at strategic points.

We gotta talk about these form elements. While the rounded corners are fun to play with having the corners all different isn't really helping the design nor is it sending a message or making a statement. This is a good experiment but save it for another project, just give the corner a subtle rousing or make them fully round all sides. I think consistency is better.

The footer looks good but the font should be Roboto. Notice the links and headings here all look the same. Use three different style styles. Links should have a style to set them apart, the heading should look like a heading, and the copy should look different from the others.

img tag is self closing

https://github.com/t0ri/personalhomepage/blob/64224b991150c7007462e794b254bd618c30e8cd/index.html#L37

The omg tag doesn't need a closing tag -> </img>

Validate your work with https://validator.w3.org it will find all of these syntax problems.