Giter Site home page Giter Site logo

goose-eggs's Issues

Validate without `load_static_elements`

I think we need a validate function/associate_function/method that doesn't include load_static_elements. But we have a validate entity and still keep validate_and_load_static_assets.

load_static_elements() does not match assets with relative paths without leading /

When switching from the old-school umami example to the goose-eggs version, I no longer got any requests to static assets. It looks like the issue is due to changes in assumptions made in the regexps used in load_static_elements():

let src_elements = Regex::new(format!(r#"(?i)src="(({base_url}|/).*?)""#).as_str()).unwrap();

Consider an example HTML that has:

<script src="assets/foo/bar.js"></script>

This fails to match because it does not have base_url or a leading /.

I'll note that the site I am testing against also makes use of:

<base href="/howdy/">

This is a case that is also not handled here, as the base should be extracted and prepended to the extracted asset path. (/howdy/assets/foo/bar.js would be the full path to request).

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.