Giter Site home page Giter Site logo

Use compiler warnings about turn HOT 3 CLOSED

tagniam avatar tagniam commented on July 25, 2024
Use compiler warnings

from turn.

Comments (3)

tagniam avatar tagniam commented on July 25, 2024

... the whole project's is completely mixed on tabs vs spaces. IMO as a separate issue this should be fixed.

... identifiers starting with an underscore and then an upper case character (like _Level, or _Player) are reserved for implementations, and using them is undefined behavior

I will soon be pushing out a code style change that will finally fix these issues once and for all. :) I previously opened an issue (#7) that tried to address this but I closed it due to inactivity.

Feel free to make a PR that fixes all the warnings you listed. As an extension, I would like to use these compiler warnings as part our Travis CI pipeline, let me know if you feel up to the task - otherwise, I'll create a separate issue for it.

from turn.

bodand avatar bodand commented on July 25, 2024

OK, I'll create the PR in a few minutes.

For the Travis CI pipeline, I have no idea as I never worked with Travis nor any CI really. In the past, I once tried using it, but it didn't really work out, so I can't say I'm up to that task.
Also, I'd look into the new GitHub actions instead, because then you can keep development completely inside GitHub. But again, I never really tried either of them.
Read below

from turn.

bodand avatar bodand commented on July 25, 2024

Oh, we already have a CI pipeline. I completely missed that. Then the CMake build should work with the warnings. As for detecting them, I have no idea.

from turn.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.