Comments (4)
The official recommendation from the CMake people is to avoid GLOB when possible.
https://cmake.org/cmake/help/v3.15/command/file.html?highlight=glob#glob
The best practice seems to be using a list of sources, so CMake can tell when there are changes and it needs to rebuild the build system. I'd recommend moving to something along the lines of what lhiny's pull request does.
from turn.
Interesting. Is there any alternative to manually adding new files in the CMake config files that does not depend on GLOB_RECURSE
? Seems unwieldy.
from turn.
Sadly, not that I know of.
from turn.
@lhiny's pull request is actually perfectly done, it even uses modern CMake paradigms like target_* macros; therefore, I say we should just merge #91, even if we just have to add the new enemies in separate PR-s.
from turn.
Related Issues (20)
- Create animated GIF of gameplay HOT 1
- Add bomb sound effect HOT 3
- Add whetstone sound effect HOT 2
- Change heal sound effect HOT 1
- Serialize/deserialize player data to/from JSON HOT 5
- Add potion sound effect
- Embed sound files in game executable HOT 3
- Health not visible when <50%
- Use compiler warnings HOT 3
- Add item selling functionality HOT 2
- Modernize random generation
- Add new item type: molotov HOT 4
- Change menu option number HOT 1
- Refactor Player::AddToInventory HOT 11
- Create RandomEvent helper function HOT 1
- wtf
- unit testing HOT 2
- Make enemy notification more interesting HOT 2
- Fix Windows specific macro checks
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from turn.