talhanation/smallships

smallships

A Minecraft Mod that add vanilla friendly Ships for travel, storage and naval warefare.

https://www.curseforge.com/minecraft/mc-mods/small-ships

All Rights Reserved unless otherwise explicitly stated.

smallships's Issues

Crash on boot Fabric 1.20.1

Requesting help.

https://mclo.gs/dUsbO3s

Ticking Entity Crash

Hi, I have been getting reports that the ships in this mod are causing ticking exceptions, my mod handles ticking entities by killing them to stop the server from bricking, but just for a sanity check, the crash does happen with the module disabled.

When Neruina enabled:

Crash when Neruina disabled:

Log

24.11 23:52:20 [Server] Server thread/ERROR Encountered an unexpected exception
24.11 23:52:20 [Server] INFO net.minecraft.util.crash.CrashException: Ticking entity
24.11 23:52:20 [Server] INFO 	at net.minecraft.server.MinecraftServer.tickWorlds(MinecraftServer.java:901) ~[server-intermediary.jar:?]
24.11 23:52:20 [Server] INFO 	at net.minecraft.server.dedicated.MinecraftDedicatedServer.tickWorlds(MinecraftDedicatedServer.java:283) ~[server-intermediary.jar:?]
24.11 23:52:20 [Server] INFO 	at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:824) ~[server-intermediary.jar:?]
24.11 23:52:20 [Server] INFO 	at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:671) ~[server-intermediary.jar:?]
24.11 23:52:20 [Server] INFO 	at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:265) ~[server-intermediary.jar:?]
24.11 23:52:20 [Server] INFO 	at java.lang.Thread.run(Thread.java:833) ~[?:?]
24.11 23:52:20 [Server] INFO Caused by: com.bawnorton.neruina.exception.DoNotHandleException: Neruina skipped handling an entity because it was disabled in the config
24.11 23:52:20 [Server] INFO 	at com.bawnorton.neruina.handler.NeruinaTickHandler.safelyTickEntities$notTheCauseOfTickLag(NeruinaTickHandler.java:120) ~[neruina-1.3.0-fabric+1.18.2-1.20.1.jar:?]
24.11 23:52:20 [Server] INFO 	at net.minecraft.world.World.wrapOperation$eob000$neruina$catchTickingEntities(World.java:14048) ~[server-intermediary.jar:?]
24.11 23:52:20 [Server] INFO 	at net.minecraft.world.World.tickEntity(World.java:480) ~[server-intermediary.jar:?]
24.11 23:52:20 [Server] INFO 	at net.minecraft.server.world.ServerWorld.method_31420(ServerWorld.java:385) ~[server-intermediary.jar:?]
24.11 23:52:20 [Server] INFO 	at net.minecraft.world.EntityList.forEach(EntityList.java:54) ~[server-intermediary.jar:?]
24.11 23:52:20 [Server] INFO 	at net.minecraft.server.world.ServerWorld.tick(ServerWorld.java:353) ~[server-intermediary.jar:?]
24.11 23:52:20 [Server] INFO 	at net.minecraft.server.MinecraftServer.tickWorlds(MinecraftServer.java:897) ~[server-intermediary.jar:?]
24.11 23:52:20 [Server] INFO 	... 5 more
24.11 23:52:20 [Server] INFO Caused by: java.util.ConcurrentModificationException
24.11 23:52:20 [Server] INFO 	at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:1013) ~[?:?]
24.11 23:52:20 [Server] INFO 	at java.util.ArrayList$Itr.next(ArrayList.java:967) ~[?:?]
24.11 23:52:20 [Server] INFO 	at net.minecraft.screen.ScreenHandler.updateTrackedSlot(ScreenHandler.java:218) ~[server-intermediary.jar:?]
24.11 23:52:20 [Server] INFO 	at net.minecraft.screen.ScreenHandler.sendContentUpdates(ScreenHandler.java:176) ~[server-intermediary.jar:?]
24.11 23:52:20 [Server] INFO 	at net.minecraft.server.network.ServerPlayerEntity.tick(ServerPlayerEntity.java:472) ~[server-intermediary.jar:?]
24.11 23:52:20 [Server] INFO 	at net.minecraft.entity.Entity.tickRiding(Entity.java:2039) ~[server-intermediary.jar:?]
24.11 23:52:20 [Server] INFO 	at net.minecraft.entity.LivingEntity.tickRiding(LivingEntity.java:2866) ~[server-intermediary.jar:?]
24.11 23:52:20 [Server] INFO 	at net.minecraft.entity.player.PlayerEntity.tickRiding(PlayerEntity.java:535) ~[server-intermediary.jar:?]
24.11 23:52:20 [Server] INFO 	at net.minecraft.server.world.ServerWorld.tickPassenger(ServerWorld.java:762) ~[server-intermediary.jar:?]
24.11 23:52:20 [Server] INFO 	at net.minecraft.server.world.ServerWorld.tickEntity(ServerWorld.java:743) ~[server-intermediary.jar:?]
24.11 23:52:20 [Server] INFO 	at net.minecraft.world.World.mixinextras$bridge$accept$204(World.java) ~[server-intermediary.jar:?]
24.11 23:52:20 [Server] INFO 	at com.bawnorton.neruina.handler.NeruinaTickHandler.safelyTickEntities$notTheCauseOfTickLag(NeruinaTickHandler.java:115) ~[neruina-1.3.0-fabric+1.18.2-1.20.1.jar:?]
24.11 23:52:20 [Server] INFO 	at net.minecraft.world.World.wrapOperation$eob000$neruina$catchTickingEntities(World.java:14048) ~[server-intermediary.jar:?]
24.11 23:52:20 [Server] INFO 	at net.minecraft.world.World.tickEntity(World.java:480) ~[server-intermediary.jar:?]
24.11 23:52:20 [Server] INFO 	at net.minecraft.server.world.ServerWorld.method_31420(ServerWorld.java:385) ~[server-intermediary.jar:?]
24.11 23:52:20 [Server] INFO 	at net.minecraft.world.EntityList.forEach(EntityList.java:54) ~[server-intermediary.jar:?]
24.11 23:52:20 [Server] INFO 	at net.minecraft.server.world.ServerWorld.tick(ServerWorld.java:353) ~[server-intermediary.jar:?]
24.11 23:52:20 [Server] INFO 	at net.minecraft.server.MinecraftServer.tickWorlds(MinecraftServer.java:897) ~[server-intermediary.jar:?]
24.11 23:52:20 [Server] INFO 	... 5 more

associated log: https://paste.shockbyte.com/legicunugequwejajeci

I tried digging around in your source but I can't find a clear indication of where it originates from.

Malformed update JSON

[Forge Version Check/INFO]: [smallships] Starting version check at https://raw.githubusercontent.com/talhanation/Ship-Mod/main/update.json
[Forge Version Check/WARN]: Failed to process update information
com.google.gson.JsonSyntaxException: com.google.gson.stream.MalformedJsonException: Unterminated object at line 10 column 4 path $.
	at com.google.gson.Gson.fromJson(Gson.java:978) ~[gson-2.8.9.jar%23121!/:?]
	at com.google.gson.Gson.fromJson(Gson.java:928) ~[gson-2.8.9.jar%23121!/:?]
	at com.google.gson.Gson.fromJson(Gson.java:877) ~[gson-2.8.9.jar%23121!/:?]
	at com.google.gson.Gson.fromJson(Gson.java:848) ~[gson-2.8.9.jar%23121!/:?]
	at net.minecraftforge.fml.VersionChecker$1.process(VersionChecker.java:183) ~[fmlcore-1.19.2-43.2.0.jar%231226!/:?]
	at java.lang.Iterable.forEach(Iterable.java:75) [?:?]
	at net.minecraftforge.fml.VersionChecker$1.run(VersionChecker.java:114) [fmlcore-1.19.2-43.2.0.jar%231226!/:?]
Caused by: com.google.gson.stream.MalformedJsonException: Unterminated object at line 10 column 4 path $.
	at com.google.gson.stream.JsonReader.syntaxError(JsonReader.java:1562) ~[gson-2.8.9.jar%23121!/:?]
	at com.google.gson.stream.JsonReader.doPeek(JsonReader.java:490) ~[gson-2.8.9.jar%23121!/:?]
	at com.google.gson.stream.JsonReader.hasNext(JsonReader.java:413) ~[gson-2.8.9.jar%23121!/:?]
	at com.google.gson.internal.bind.MapTypeAdapterFactory$Adapter.read(MapTypeAdapterFactory.java:184) ~[gson-2.8.9.jar%23121!/:?]
	at com.google.gson.internal.bind.MapTypeAdapterFactory$Adapter.read(MapTypeAdapterFactory.java:145) ~[gson-2.8.9.jar%23121!/:?]
	at com.google.gson.Gson.fromJson(Gson.java:963) ~[gson-2.8.9.jar%23121!/:?]
	... 6 more

Nothing crash worthy, just an unneeded stacktrace in the logs

Inconsistent Collisions, falling through ships

Seems like every ship has an inconsistent collission box that doesn't extend far enough the edges. I fall through ships if I'm too close to the bow or stern, and this also causes some ugly merging when getting close to other ships while piloting one.

Please fix collision boxes. Thank you for your time and consideration