tama/pogo-discord-mod-bot

Simple mod tasks on a (pokemon go related) discord server

pogo-discord-mod-bot's Issues

Refactoring to split logic and calls to discord api

Put all discord related code in another place and re-wiring.
Will make tests and bug fix easier to do.

Environment and CI/CD

Global "issue" to track code related to environment and CI and/or automated builds + tests.

Some kind of alert when the bot is down/not responding

Have some kind of alert(s) when the bot is not online and/or not responding to commands (push notification ? email ?) to be able to see what's wrong quickly.

Ideally, give the administrators some way to manually reboot via some interface (website + login with discord ?)

Raid time message formatting is not correct

See picture :

Command to create an EX raid channel

As a user with enough rights send a specific command in the right channel, the bot should :

• Create a new channel in a configurable category with specific permissions : no one except people with admin rights & bots & a specific role can read and post inside
• Create a new role for this channel

An admin can then use another command to set the role to someone and grant it access to read/write in the channel

Bonus : Automatically delete the channel and the role once the EX raid is done

Add project status and coverage to readme

Thanks to travis, we could add badges like the status of the project or the coverage to the readme. This is a nice touch as it will motivate us to have a better coverage.

Logs

Have the bot log everything it received and did for analysis purposes (Commands received, errors encountered...)

Revamp raid announcement format

The query should be easier to use, notably for phone user

We should:

• clear double space by itself
• take care of the @ issue (sometimes, the auto-correct on the phone places a space after a @)
• fix formatting for hours (9h10 should work)

That's all I can think of for now, I am sure we could find other small issue that would greatly improve the announcement feature

Some command to quickly delete a raid channel (only users with pre-defined roles can use it)

Have some command to quickly delete and archive a raid channel (in case the bot didn't pick up the finished raid channels for a long time, or someone need to quickly delete a batch of channels).

Of course, this command is dangerous so only users with some role can use it.

Sometimes the bot doesn't clean the finished raid channels

The bot is still running ("clean" messages in log to indicate it's running) but it does not archive the raid channels. Restarting it manually usually solve the problem.

Use mocks to test critical path

The test coverage is (probably) bad, and some bugs can't be catched with only unit tests. We should implement a mocking strategy to test the commonly used command so that we can never break it.

Delete the expired raid commands after some time

To avoid cluttering the channels where all the commands are sent, have some command to clean the old commands (more than X hours/minutes old ?), or some script that can be launched every night automatically.

Bonus : configurable "expiration time" by server, and discord admins can choose to opt-out if they don't need it

Error message for "!raid .... @9h37" (starting time < 10:00)

The bot does not create a new channel if the time given in the command is H:MM and not HH:MM (e.g !raid test gym @9h37)

(Related : issue #9)

Mimic chat bot interaction for raid creation

When a user gives an ambiguous name for a gym, we answer with all the possibilities. Maybe we can implement these possibilities as clickable button, that would create the corresponding raid?

1. Make buttons for all arena + one for none of the above
   2a. Pressing a button will send a !raid message with the correct information
   2b. Pressing a button will remove the message

Discord users can edit the time themselves if it is wrong without having to call for help

As of now the only way to correct raid times is to call someone with "manage channel" permission to manually change the time.
The solution is to have some kind of command to manually correct the time of an existing raid channel (mod-bot acting as a proxy).

Add new date format

I've seen some people use the @h format, truncating the minutes. It's an edge case but it's really easy to add

bot crash

it crash after 1 minute

(bot-env) root@59997-53573:/home/pogo-discord-mod-bot/mod_bot# python3 main.py
reading configuration
on_ready
{}
Traceback (most recent call last):
File "main.py", line 443, in
loop.run_until_complete(asyncio.gather(run(token), modtask()))
File "/usr/lib/python3.7/asyncio/base_events.py", line 584, in run_until_complete
return future.result()
File "main.py", line 296, in modtask
warn_interval = int(get(server.id, "mod.warn_interval", conf))
TypeError: int() argument must be a string, a bytes-like object or a number, not 'NoneType'

Incorrect start time when using raid command

• Enter !raid boss gym 13h50
• Expected output in created raid channel : 13h05 -> 13h50
• Actual output in created raid channel : 14h05 -> 13h50