tamtam180/cityhash-for-java

CityHashのJava実装 / same as v1.0.0 version, not same v1.1.1

cityhash-for-java's Issues

Result inconsist with python cityhash64

I have try to use this cityhash64 func, but find out the result is inconsist. Can u please take a look.

from cityhash import CityHash32, CityHash64, CityHash128

print(CityHash64('abc'))
print(CityHash64('123'))

    public static void main(String[] args) {
        String itemId = "123";
        byte[] bytes = itemId.getBytes(StandardCharsets.UTF_8);

        for (int i = 0; i < bytes.length; i++) {
            System.out.println(bytes[i]);
        }

        System.out.println(toUnsignedString(cityHash64(itemId.getBytes(), 0, itemId.length())));
        System.out.println(toUnsignedString(cityHash64("abc".getBytes(), 0, itemId.length())));
    }

inconsistent with Python/Go/C++

go to
https://github.com/cheungyida/cityhash

Defination of parameter "pos" in function cityHash64WithSeed

Regarding below function cityHash64WithSeed,
public static long cityHash64WithSeed(byte[] s, int pos, int len, long seed)
May I know why it has addtional parameter "pos" comparing with one in C++ ？
And what is the purpose of "pos"?

Below is original C++ code of this function for your information:
uint64 CityHash64WithSeed(const char *s, size_t len, uint64 seed) {
return CityHash64WithSeeds(s, len, k2, seed);
}

thanks a lot.

maven support?

can you publish your file to maven?

This implementation is compatible to the 1.0.0 implementation version.

original 1.0.0 / at Apr 6, 2011: google/cityhash@6efae23
And my code committed at Apr 6, 2012.

After then, the original implementation has been upgraded several times and the hash value has changed.

Histories:

• CityHash v1, April 11, 2011 <= this code as same
• CityHash v1.0.1, April 28, 2011
• CityHash v1.0.2, May 8, 2011
• CityHash v1.0.3, October 6, 2011
• CityHash v1.1, October 22, 2012

see: https://github.com/google/cityhash/blob/master/NEWS

Note which version of the implementation is compatible.