keeps running test function after failed assert

[tapjs]

keeps running test function after failed assert

[isaacs]

That's by design. I have some projects that run a few hundred assertions, and it's very useful to see exactly which tests pass and which fail, rather than just the first failure.

That being said, it'd be nice to have it return the result so that you can check it to decide whether or not to keep going.

[mvolkmann]

I can somewhat understand that design choice, but I still think there's an issue. Notification of failed assertions is lost if an error occurs after those assertions. In many cases the cause of the error is directly related to those failed assertions. My example demonstrates that. I think it would be far less confusing if tap output messages about the failed assertions even if an error occurs after them.

[isaacs]

I see. So, you're saying a throw should sort of imply a .end(), and print out the assertions that were run up to that point? Seems reasonable.

[mvolkmann]

Yes, I think that would be a nice improvement.

[felixge]

+1 I strongly agree with this. @isaacs would you accept a patch?

[aredridel]

Hm. We do the opposite at work, and it's very useful to get the full output -- sometimes the later errors give some info as to what happened, too.