tardis-sn/tardis-refdata

TARDIS repo for reference data for the integration tests

tardis-refdata

TARDIS repo for reference data for the integration tests

This repository is mirrored at https://[email protected]/tardis-sn/TARDIS/_git/tardis-refdata and synced automatically through a pipeline located at .github/workflows/sync-mirror.yml.

Always check if binary files are tracked by Git LFS before pushing changes.

Contribution guidelines

By redirecting to this link, you can find the contribution guidelines.

tardis-refdata's Issues

Install Bokeh is incorrectly being cancelled on test failure in compare refdata pipeline

Describe the bug
Bokeh module is not installed when a test fails in the compare refdata pipeline

To Reproduce

Run the refdata compare pipeline with the test_montecarlo_main_loop failing

Screenshots

https://dev.azure.com/tardis-sn/TARDIS/_build/results?buildId=3917&view=logs&j=c4cecf7d-00da-5588-6d0f-f57e9b174e2b&t=c8083de3-f1c3-540d-f007-580df721b41b&l=244

System

• OS:

  • GNU/Linux
  • macOS

• Environment (conda list):

Additional context

Clean up plots to be both larger and have clear units

The Bokeh plots are somewhat small and lack units. They also have scaling issues when the difference in the values gets very small. Wavelengths converted to Angstroms would also be more readable for most astrophysicists.

Plot Luminosity Against Wavelength in `ref_data_compare` Notebook

@jamesgillanders said that wavelength vs luminosity graphs would better highlight the discrepancy between models for him.
"This would also be good because then we can obviously see where the wavelengths are that have the biggest deviation, which we can then use to quickly infer the culprit transitions (since these are very commonly referred to in wavelengths; e.g. He I 10830 AA line)
Basically, when I see a deviation at e.g. 3e15 Hz, I then have to compute what wavelength that is to then determine what species is causing the issue
Not sure how many new graphs we would need - I just want to see the same plots that are already there, but with version in wavelength as well as frequency"

Axis labels mismatch in ref_data_compare notebook

Describe the bug

The axis labels for the refdata plots are mismatched:

tardis-refdata/notebooks/ref_data_compare.ipynb

Lines 489 to 498 in 2dc757e

	" p = figure()\n",
	" spectrum1 = ColumnDataSource(pd.DataFrame.from_records({'x': ref1_nu.values, \n",
	" 'y': ref1_L}))\n",
	" spectrum2 = ColumnDataSource(pd.DataFrame.from_records({'x': ref2_nu.values, \n",
	" 'y': ref2_L}))\n",
	" p.line('x', 'y', source=spectrum1, legend_label='ref 1')\n",
	" p.line('x', 'y', source=spectrum2, legend_label='ref 2', color='#ff7f0e')\n",
	" p.xaxis.axis_label = \"L\"\n",
	" p.yaxis.axis_label = \"nu\"\n",
	" p.xaxis.formatter.precision = 1\n",

This should also be changed in ref_data_compare_from_paths.ipynb

To Reproduce

Screenshots

System

• OS:

  • GNU/Linux
  • macOS

• Environment (conda list):

Additional context

Readme.MD on tardis-refdata contains broken links

`packet_unittest.h5` binary file is not LFS stored

Readme Required to get a better idea of repo

Add documentation
Licence Information
contributions guidelines ,etc in the readme file