tarecord/sign-in-with-google

A WordPress plugin that adds "Sign in with Google" functionality

Hi there 👋

sign-in-with-google's Issues

Use login_redirect for redirecting user after authentication

https://github.com/NorthStarMarketing/sign-in-with-google/blob/b413bfb253855b7456bc96c9654ceccbcc6bcb3c/src/sign-in-with-google/admin/class-sign-in-with-google-admin.php#L539

WordPress provides a login_redirect hook which would be the preferred method of redirecting the user after authenticating.

Difference between branches

Can you explain the difference between branches? develop branch is set as main, so is master obsolete branch we should ignore?

The Login button not displayed

The domain restricted is not the same as the domain this plugin is installed in.

Plugin Setting Page:

Google Developer Console Setting:

Thank you for any advise. Appreciate this plugin very much.

Add validation user is attempting to connect their account

https://github.com/NorthStarMarketing/sign-in-with-google/blob/b413bfb253855b7456bc96c9654ceccbcc6bcb3c/src/sign-in-with-google/admin/class-sign-in-with-google-admin.php#L488-L496

Slows down site

The plugin slows down my Wordpress site a bit. Is it possible to only load the plugin when necessary? Perhaps only when the user is logged out and on the relevant pages (login page and google response page).

EDIT: Checked out the code a bit and I wonder if it is the loading of the dependencies on every page load that slows it down.

release request

@tarecord could you publish a new release with #73 included?
thanks

Show Error For Users With Same Name

When a user tries to sign in with another Google account that shares the same name, there's no error message stating why the user can't be logged in. In the debug.log it states:

[12-Feb-2019 13:42:29 UTC] Sorry, that username already exists!

So we're getting it, but a meaningful error message on the login screen needs to be added or we need to handle it another way.

NOTE: This should be a rare edge case. User has to have two different email addresses (both of which have domains allowed in the admin) with the same first.last naming convention

Utilize the WordPress 'Remember Me'

Original request: https://wordpress.org/support/topic/remember-me-option-4/

Hello,

Would it be possible to pass on the “Remember Me” paramater to the plug-in? I patched it for now, it is really super simple.

Thanks

Redirects to site but doesn't login

I've installed the plugin. Upon selecting and authenticated with my G-Suite credentials, I'm redirected to my site. However, I'm not logged in. I don't see any errors or logs.

Show log in with Google button on custom login form

Hey,

Is there a way to show the log in with Google button in a custom login form?

for example in this:
<form method="post" action="<?php echo wp_login_url(); ?>"> <input type="text" name="log"> <input type="password" name="pwd"> <input type="submit" name="wp-submit" value="Login" ></form>

Thanks in advanced for the help

Fails When Redirecting After User Logs Out

After users log out, they see the login form. From here, they are able to log back in, however, the redirect back fails with just a white screen after they are authenticated with Google.

Steps To Reproduce:

1. Sign in to the site
2. Log Out
3. From the wp-login.php?loggedout=true screen, click the "Sign In With Google" button
4. See the white screen

Register User

I would suggest to allow user registration only if the option is selected on General settings.

If not, return an error.

Multisite support

Please implement functionality required to use the plugin on a multisite network.

When doing a multisite install of the plugin, at the moment, it is required to set up the plugin for each site that is added.
Please add a multisite settings page that allows administrators to override per-site settings.

Thank you!

Issue with Members plugin

There is an issue with Members plugin when “Redirect all logged-out users to the login page before allowing them to view the site.” is enabled.

When you click “Sign in with Google”, it redirects you back to the login page, not in google SSO page.

I tried another “login with google” plugin and it works fine with this option enabled.

View: https://wordpress.org/support/topic/issue-with-members-plugin/

Is development of this plugin discontinued?

We have tried to contact you through email, also comments under PR, but nowhere get response for a very long time.
Can you please say with one word (yes or no) if the plugin is abandoned or not? we are waiting the PR's to be merged, and if you are no longer interested in the development, we will have to fork it and continue on our own (which I try to refrain from unless you have abandoned this plugin).

Login Redirect

In class-sign-in-with-google-admin.php, line 561, you have

wp_redirect( apply_filters( 'login_redirect', $redirect ) );

with only one argument instead of 3 (https://developer.wordpress.org/reference/hooks/login_redirect/). This causes error when hooking to 'login_redirect', such as when redirecting based on user role. Will you be able to change it to accept all 3 arguments as documented here: https://developer.wordpress.org/reference/hooks/login_redirect/? Thanks.

Fix PHPCS Warnings: "Use strict comparisons"

FILE: ...h-google/src/sign-in-with-google/admin/class-sign-in-with-google-admin.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
--------------------------------------------------------------------------------
 228 | WARNING | Found: ==. Use strict comparisons (=== or !==).
 507 | WARNING | Found: !=. Use strict comparisons (=== or !==).
 545 | WARNING | Found: !=. Use strict comparisons (=== or !==).
 559 | WARNING | Found: !=. Use strict comparisons (=== or !==).
 612 | WARNING | Found: !=. Use strict comparisons (=== or !==).
 704 | WARNING | Not using strict comparison for in_array; supply true for
     |         | third argument.
--------------------------------------------------------------------------------

After login has happened, plugin should still respect the redirect_to query string.

In cases where you can send the visitor to the Login page using auth_redirect() a variable is passed called redirect_to with the URL appended. The plugin should respect this value and redirect there once the user is authenticated.

No file named sign-in-with-google-admin.js

https://github.com/NorthStarMarketing/sign-in-with-google/blob/201fa9d067fd54ebe54734e0de467396477cf1e2/src/sign-in-with-google/admin/class-sign-in-with-google-admin.php#L116

Issue after upgrading 1.7 > 1.8

Hi,

after upgrading to 1.8 I am getting the following error message:

Notice: Undefined variable: user in /www/htdocs/path_to_site/wp-content/plugins/sign-in-with-google/src/admin/class-sign-in-with-google-admin.php on line 572

Warning: Cannot modify header information - headers already sent by (output started at /www/htdocs/path_to_site/wp-content/plugins/sign-in-with-google/src/admin/class-sign-in-with-google-admin.php:572) in /www/htdocs/path_to_site/wp-includes/pluggable.php on line 1340

Warning: Cannot modify header information - headers already sent by (output started at /www/htdocs/path_to_site/wp-content/plugins/sign-in-with-google/src/admin/class-sign-in-with-google-admin.php:572) in /www/htdocs/path_to_site/wp-includes/pluggable.php on line 1343

I replaced some private data with "path_to_site".

Wordpress 5.8.4
PHP 7.4

I am logged in spite of the error messages.
Reentering the website admin url opens the backend.

How can I fix the error messages?

Cheers

Error 400: redirect_uri_mismatch

the redirect URI in the request, https://harlunfh.com/?google_response, does not match the ones authorized for the OAuth client. To update the authorized redirect URIs, visit: https://console.developers.google.com/apis/credentials/oauthclient/${your_client_id}?project=${your_project_number}

Woocommerce integration

Thank you for the plugin 🙏 Do you have any plans to extend this plugin to also add google sign in to the WooCommerce login?

Need to ask for consent

Here's the issue i am facing..

1. I have a personal Google Account.
2. My Company also has Google apps accounts.
3. Now on my WP, i have enabled to restrict the logins only from my company domain name.
4. i am logged in to the only personal gmail from the browser.
5. Now, when I open the wp site and try to login its failing and alerting me that only domainname.com are allowed. This is expected.

Shouldn't it take me to the google login page and allow me to signin with my CorpAccount?

However, if i login to google first with my both of the accounts and then open the WP sire, its asking me to select the account with which i should login.

make disallow of registration configurable

In #56 a check was added to disallow the registration of new users if the setting anyone can register is not checked in Wordpress.
Would it be possible to make this configurable?
Background: I do not want that anyone can register without google but I do want that users of a speific domain can register with google.

Can't sign in if `Restrict To Domain` field is blank

On the admin page, there's text saying the Restrict To Domain field can be blank. When it's blank though, I get an error when logging in.

Screenshots

Admin page

Sign in page

Google+ API shutdown

Google is shutting down the Google+ API.

Filter Redirect Slug

It would be great to provide developers with a way to filter the redirect slug (google_response) and a custom base site url. ( re: #89 )