tatulund/badge

Simple Java API for Lumo Badges

badge's Issues

Badge theming and styling didn't work with Vaadin 23.0

The badge component didn't react to the given themes and variants with Vaadin 23.0.2

Setting the text of badge, adds another instance of span with the new value

In version 2.2.2 (V23 branch)

    /**
     * Set the text content of the badge, remove all other content.
     * 
     * @param text
     *            String value.
     */
    public void setText(String text) {
        this.text = text;
        add(new Span(text));
    }

Doesn't remove old content as stated in javadoc,
so we just get more spans and texts added every time we call badge.setText(..).

Badge looks incorrect with Safari, MacOS

Badge with .setPill(true), Vaadin Flow 23.2.1, looks incorrect with Safari (version 16.0 (17614.1.25.9.10, 17614)) under MacOS (Monterey, 12.6):

Looks as it should with Firefox, Chrome, Opera, Edge under the same MacOS:

Badges have two layers of background

This is on Vaadin 24.

looks like it badge styling applies on the outer element as well, based on theme

I think if the badge is inside the shadowdom (and no badge styling imported for that shadowdom) then it applies properly only on the inner level.
It was nice when it was just the span element in the version 1.0.0, but I guess it didn't work for v23?

new Badge("3")