taylorjg/angular2dialog

Angular 2+ app demonstrating a form with validation inside an ng-bootstrap modal dialog

angular2dialog's Issues

Deprecation warning

After updating to Angular 4.0.3, the following warning message appears in the console:

The <template> element is deprecated. Use <ng-template> instead ("[WARNING ->]<template ngFor [ngForOf]="parts" let-part let-isOdd="odd"><span *ngIf="isOdd" class="{{highlightClas"): ng:///t/t.html@0:0

I think this is something to do with ng-bootstrap:

• ng-bootstrap/ng-bootstrap#1337

Keep an eye on the above issue and update ng-bootstrap when a fix is available.

First click of Cancel button doesn't dismis modal

Steps to reproduce:

• Click the Add Item button
• The modal is displayed with the focus in the "First name" input element
• Click the Cancel button (using the mouse)
• The modal is not dismissed. A validation error for the "First name" field is displayed.

Note that clicking the Cancel button again does dismiss the modal. Also, the first click of the Cancel button works as expected when editing an existing item.