Comments (9)
Thanks for the heads up! I believe we can just convert the 32 to 31, it's an upper limit on how long a slice can be (which is actually 1<<31 for 32 bit systems since Len()
returns an int
).
from minify.
Can you try v2.20.29 and tell me if it works?
from minify.
Hello,
the new versions gives the same error type but different value
# github.com/tdewolff/minify/v2/bindings/py
bindings/py/minify.go:28:12: invalid array length 1 << 31 (untyped int constant 2147483648)
bindings/py/minify.go:37:12: invalid array length 1 << 31 (untyped int constant 2147483648)
# github.com/tdewolff/minify/v2/bindings/js
bindings/js/minify.go:28:12: invalid array length 1 << 31 (untyped int constant 2147483648)
bindings/js/minify.go:37:12: invalid array length 1 << 31 (untyped int constant 2147483648)
from minify.
Off-by-one error, please check v2.20.30!
from minify.
Hello,
the 32bit build is unfortunately still broken.
- the 2.20.30 commit only fixes one instance of the previous problem:
the goStringArray has the new -1, the goBytes still has 31
- after patching 1 we get a new problem which can be seen in the screenshot below (i only patched the python bindings for problem 1).
from minify.
Must have been late, how does v2.20.31 do?
from minify.
Hello,
I still get the same result unfortunately:
from minify.
I really hope this is now fixed in v2.20.32, I have no idea why the address space for 32-bit systems is not math.MaxInt32-1 == 1<<31 - 1
...
from minify.
Hello,
2.20.32 seems to be working
Thank you :)
from minify.
Related Issues (20)
- fails to correctly minify undici HOT 9
- Minifying CSS in a HTML document which uses Mustache template, incorrectly minifies HOT 4
- How to minify HTML, but only HTML and JS i.e. excluding CSS HOT 2
- Javascript option to preserve string newline or char codes HOT 8
- xmlns attribute is required for single SVG file HOT 3
- XML CDATA minify issue HOT 12
- Minifier always transforms `!(string)` to `!1` even if the string is empty. HOT 1
- Removing parenthesis of expression containing optional chaining can make different output HOT 1
- Accessing property of object should be considered as side effect-able expression. HOT 3
- CLI doesn't handle directory inputs with trailing forward slashes on Windows HOT 1
- `npm i @tdewolff/minify` fails on Windows HOT 3
- `undefined` can be redeclared in function body
- Add arm64 builds for node package
- HTML: closing tag for '<p>' purged HOT 2
- minify.exe run error Exception 0xc0000005
- css: Whitespace between values isn't collapsed
- html: Whitespace isn't collapsed when text includes "&"
- js: Issue when minifying firebase - works without
- Not Respecting ES Version (Chaining)
- Create a command line option to disable JS: shorten true, false, and undefined to !0, !1 and void 0
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from minify.