Giter Site home page Giter Site logo

Comments (3)

tdewolff avatar tdewolff commented on July 17, 2024 1

Good point, this should be fixed in the latest release!

from minify.

tdewolff avatar tdewolff commented on July 17, 2024

Thanks for raising this issue. The XMLNS attribute should only be removed when the SVG document is "inline". This is only activated for SVG elements inside HTML. Otherwise, a regular SVG document is not considered inline and should thus not remove the XMLNS attribute. It is strange that this does happen for you, could you show me an example that reproduce this behaviour?

from minify.

marmooo avatar marmooo commented on July 17, 2024

Sorry for the lack of examples.
After further investigation, it appears to be a random bug.
It seems to happen about 70% of the time.
Since it was not possible to check without a certain number of files,
I will provide an example of a repository where the error occurs.

go install github.com/tdewolff/minify/v2/cmd/minify@latest
git clone https://github.com/marmooo/touch-kanji
cd touch-kanji
minify src/favicon/favicon.svg  # --> ok
minify -r docs -o .  # --> sometimes fail

The easiest way to check is to enter the following commands:

cd touch-kanji
minify -r docs -o .
git status  # <-- if docs/favicon/favicon.svg is added, it's a bug. 

from minify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.