team-charls/jpegls-wic-codec

Windows Imaging Component (WIC) codec for JPEG-LS .jls files

jpegls-wic-codec's Issues

fatal error C1001: Internal compiler error

Hello.
I downloaded the jpegls-wic-codec code using git (current commit 374a569). When I try to compile it, I get the error:

1>winrt.ixx
1>...\jpegls-wic-codec\build\intermediate\jpegls-wic-codec\x86\Debug\Generated Files\winrt\base.h(5041,71): fatal error C1001: Internal compiler error.
1>(compiler file 'msc1.cpp', line 1603)
1> To work around this problem, try simplifying or changing the program near the locations listed above.
1>If possible please provide a repro here: https://developercommunity.visualstudio.com
1>Please choose the Technical Support command on the Visual C++
1> Help menu, or open the Technical Support help file for more information
1>INTERNAL COMPILER ERROR in 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\bin\HostX86\x86\CL.exe'
1>    Please choose the Technical Support command on the Visual C++
1>    Help menu, or open the Technical Support help file for more information
1>Done building project "jpegls-wic-codec.vcxproj" -- FAILED.

Visual Studio Community 2019 version 16.11.35.

Can you get around this problem?

Dependency on mfplat.dll (Media Feature Pack)

jpegls_bitmap_frame_encode::WritePixels uses MFCopyImage, which comes from mfplat.dll, part of Media Feature Pack. Not every version of windows will support this out of the box.

I think it would be good to have one less dependency, and it would make the code easier to understand.

The code in question is here:

jpegls-wic-codec/src/jpegls_bitmap_frame_encode.h

Lines 189 to 190 in 575d883

	winrt::check_hresult(MFCopyImage(reinterpret_cast<BYTE*>(destination), static_cast<LONG>(destination_stride),
	pixels, source_stride, static_cast<DWORD>(destination_stride), line_count));

and I propose that this be replaced with the implementation that wine uses, found here:
https://github.com/wine-mirror/wine/blob/e909986e6ea5ecd49b2b847f321ad89b2ae4f6f1/dlls/mfplat/main.c#L1510-L1522

I'm happy to submit a PR, if there's any interest in this.

Document gray 16bits appears as black

From the main README it appears as if a 16bits would be displayed (at least low bits). On my system it is displayed as black:

Would it be possible to clarify the toplevel README ?

Windows Photo Viewer cannot load jls files

After register dll, Windows Photo Viewer still load jls files failed.