teammetallurgy/aquaculture

Aquaculture is an expansion of Minecraft's base fishing system. It allows you to catch a variety of new fish with a brand new series of rods and tools

Aquaculture 2

An enhancement of Minecraft’s piscatorial system. The catch is always a surprise. Each biome harbors countless fish that are exclusive to its environment, and a plethora of new loot items await you as you cast your line.

How to get Aquaculture through maven

Add to your build.gradle:

repositories {
  maven {
    // url of the maven that hosts Aquacultures files
    url "http://girafi.dk/maven/"
  }
}

dependencies {
  // compile against Aquaculture
  compile fg.deobf("com.teammetallurgy.aquaculture:aquaculture2_${mc_version}:${mc_version}-${aquaculture_version}")
}

${mc_version} & ${aquaculture_version} can be found here, check the file name of the version you want.

aquaculture's Issues

Tackle Box dupe on LAN server

When opening the Tacklebox on LAN with my friend, I managed to see his fishing rod, and I could upgrade it.

This has also allowed me to dupe a hook i placed into the tacklebox, by picking it up, and placing it down in the upgrade slot. I cannot really tell if my friend clicked the slot at the same time or so, but I ended up with 2 instances of the hook, and it wasn't a client dupe. after restarting we still had 2 hooks.

Maybe have the upgrade container only be accessible on a per client base ? like the crafting table.
The storage space could still be used as a chest and as a 'view for all'.

Add localization support for Message In A Bottle

Messages can't be translated. This class -> ItemMessageInABottle.java

EnviroMine compatibility

I think because the Fish have some special tags on them for their Weight in LBS… they aren't recognized as items that can have Rot Times on them, in Enviromine. Can you look into the rot mechanics and see if something can be done there so that Fish can be set to Rot into other items (such as Rotten Food) in Enviromine.

Some foods can let them kicked from Server

When my player eat some food it will be kicked from Server.
https://i.loli.net/2019/01/09/5c355fe221466.png

And I try to play Single Game. I still be kicked from Client.
This is crash-report
https://paste.dimdev.org/bijesegulu.mccrash?tdsourcetag=s_pcqq_aiomsg

My English is not well. Sry.

Error: Biome ID already registered at startup

[21:45:07] [Server thread/INFO] [STDOUT]: [com.teammetallurgy.aquaculture.loot.BiomeType:addBiome:32]: [Aquaculture] Error: Biome ID 30 already registered as BiomeType:Arctic when trying to register BiomeType:Arctic

[21:45:07] [Server thread/INFO] [STDOUT]: [com.teammetallurgy.aquaculture.loot.BiomeType:addBiome:32]: [Aquaculture] Error: Biome ID 10 already registered as BiomeType:Arctic when trying to register BiomeType:Saltwater

[21:45:07] [Server thread/INFO] [STDOUT]: [com.teammetallurgy.aquaculture.loot.BiomeType:addBiome:32]: [Aquaculture] Error: Biome ID 26 already registered as BiomeType:Arctic when trying to register BiomeType:Saltwater

[21:45:07] [Server thread/INFO] [STDOUT]: [com.teammetallurgy.aquaculture.loot.BiomeType:addBiome:32]: [Aquaculture] Error: Biome ID 6 already registered as BiomeType:Freshwater when trying to register BiomeType:Brackish

[21:45:07] [Server thread/INFO] [STDOUT]: [com.teammetallurgy.aquaculture.loot.BiomeType:addBiome:32]: [Aquaculture] Error: Biome ID 134 already registered as BiomeType:Freshwater when trying to register BiomeType:Brackish

[21:45:07] [Server thread/INFO] [STDOUT]: [com.teammetallurgy.aquaculture.loot.BiomeType:addBiome:32]: [Aquaculture] Error: Biome ID 14 already registered as BiomeType:Freshwater when trying to register BiomeType:Mushroom

[21:45:07] [Server thread/INFO] [STDOUT]: [com.teammetallurgy.aquaculture.loot.BiomeType:addBiome:32]: [Aquaculture] Error: Biome ID 15 already registered as BiomeType:Freshwater when trying to register BiomeType:Mushroom

Fillet Knife tag is invalid

Version: 2.0.1

It's also a very strange choice to put this tag under forge's namespace instead of aquaculture's.

Add support for modded biomes

Pick up on freshwater biomes from other mods by using the BiomeDictionary, same deal with saltwater.

Crash when i catch a fish with any rod

https://pastebin.com/8hU3fKpf

Neptunium hoe problem

The problem I have encountered was that whenever I went to till the land with the hoe, I was unable to plant seeds on the tilled land. Can anyone show me a solution?

Fillet Knife taking durability when making fish fillets in creative.

title says it all.

No squids spawning?

So after i added this mod to my modpack and server we had no spawns of minecraft squid anymore.

[Bug] Neptunian Legs & Chestplace have mixed-up armor values

The armor values for the Neptunium Chestplate and Leggins appear to be swapped.
The Chestplate gives +6 armor, while the Platelegs give +8 armor.
This wasn't the case in the older versions of Aquaculture and is also inconsistent with vanilla, where chestplates always gives more armor than leggins.

Buckets Disappear on Fish Release

I noticed that when you release a fish from a bucket you don't get the bucket back like you do with vanilla fish.

[Bug] Enchanting book don't have JEI/WAILA description

Self-explanatory, must add
description.enchantment.ENCHANTMENTNAME to lang file

Bobber Options

Unlocked via Advancements #32 they allow you to customize your bobber a little bit. Either through a tackle box or a side inferface tab on the inventory, TBD.

Restructure folders

Change "java/rebelkeithy/mods/aquaculture" structure to "java/com/teammetallurgy/aquaculture". This shouldn't break anything?

Neptunium armor/tools cannot be repaired

As subject says, neptunium armor and tools cannot be repaired with neptunium ingots unfortunately. latest version for 1.12.2

[Feature] Advancements

A series of 24+ Advancements for Aquaculture. For now, their rewards are minor but later on they may reward unique bobbers for fishing (as seen in other notes.)

Names, descriptions, etc. subject to change.

https://docs.google.com/spreadsheets/d/1BD_caeYwt1aQJyVv04C3maH79W5EnWPjXJFReFv9ECw/edit#gid=0

Normal Advancements
The Right Gear | Craft an Iron Fishing Rod
Bluebird Skies | Catch a fish during the day.
Overcast Cast | Catch a fish in the rain.
High Flying | Catch a fish high above sea level.
Deep Dive | Catch a fish underground.
Night Fishing | Catch a fish at night.
That's Not Ice Fishing | Catch a fish while it is snowing.
Definitely Not Low Fat | Eat a Whaleburger
Fishing for Trouble | Hook a Creeper with a fishing rod.

Goals
Showing Off | Craft a Gold Fishing Rod
Pond Pro | Catch all 8 Freshwater species.
Jungle Jig | Catch all 4 Tropical species.
Salty as the Sea | Catch all 5 Saltwater species.
Desert Rodman | Catch all 4 Arid species.
Arctic Angler | Catch all 7 Arctic species.
Whale of a Tale | Catch a Whale.
Jellyfishing | Catch a Jellyfish.
Take a Bite | Catch a Shark.
An Inkling | Catch a Squid.

Challenges
Is That Necessary? | Craft a Diamond Fishing Rod
The Biggun | Catch the largest of a species.
Lightweight | Catch the lightest of a species.
Lightning Rod | Get struck by lightning while fishing.
Couple of Fungis | Catch both Shrooma species.

Aquariums

Aquariums are glass boxes that spawn renders of the icons of the fish in them to wander around inside them. The scale of the fish icon is based on its weight compared to its maximum weight. Could have a few different sizes of Aquarium, small would hold 1 fish, medium 2, large would be a 2x1x1 that stores 4 fish.

Recipe would involve gravel, glass panels and a bucket of water. Larger aquariums more of each or might just be a smaller aquarium + extra ingredients.

Suggestions for additional config options

Here are some suggestions I have for improving cross-mod compatibility, configurability, and addressing other minor issues in Aquaculture.

• Currently, fish that are caught don't stack, presumably because of mismatched "Weight" NBT. A config option to disable this or make it irrelevant to stacking (if possible) would be a nice improvement.
• Being able to configure the loot received from the Box, Lockbox, Treasure Chest, and Neptune's Bounty as a list of (ItemID:meta, weight/rarity) entries.
• Better configuration for catchable fish / junk (fishables). Something like this, with default entries for items added by the mod:

S:biome <
    ItemID:meta, weight/rarity
>

Where biome is "all", a biome name, BiomeDictionary type, or a biome group (defined elsewhere in the configuration, to reduce the number of redundant entries you'd have to make).

• Config options to enable a recipe for the Aquaculture Wooden Fishing Rod, and different recipes for the iron, gold, and diamond fishing rods (in the case Thermal Foundation or another mod that adds fishing rods with a conflicting recipe is in the user's pack)
• Alternative solution to the above problem: I'm currently solving this issue in my pack by replacing the output of the recipes for the vanilla Wooden Fishing Rod and conflicting Thermal Foundation Fishing rods, making them return Aquaculture fishing rods instead. I then add shapeless recipes that allow you to cycle between an undamaged Aquaculture fishing rod and an undamaged conflicting fishing rod.
• Config option to use Tinkers' Construct tool rods (or any oredict-compatible item) to construct Aquaculture fishing rods instead of ingots. They use oredict entries like "ironRod" and "rodIron" for tool rods.
• Config option to change the smelting recipe for a tin can to return a tin ingot or 4 tin nuggets instead of an iron ingot
• Programmatic configuration of fishables / box loot via a Java API.

(edit: Thermal Expansion -> Thermal Foundation)

[Configs] Neptunium Configs

Add the option to configure Neptunium Durabilities or disable the Neptunium Chest from drop tables entirely.

Modded Biome Support

Would it be possible to add support for modded biomes, such as those added by Traverse or Biomes o Plenty? Right now, you -can- catch Aquaculture's fish in modded biomes, but only freshwater fish will show up, rather than saltwater fish, desert fish, etc.

Knife Recipe Issues

Hello,

s there a way to change the recipe for the knife?
This is in conflict with the mod: TrinityWeapons

Or is it possible to change this self?

[Request] Oredict fish

It would be nice for cross-mod compatibility if every fish was registered in the fish oredict entry.
Perhaps exlude special catches such as the Turtle and Fish Bones.

Infinite Fish spawning in Village wells. Superflat world

Enchantment Localization Short Desc Missing

Feature Request: Configurability

Would it be possible to get more configuration options?

• Ability to configure the probability of a catch (right now fishing is just way too easy)
• Ability to enable/disable each type of catch and loot

[1.11.2] According to Applecore, some of your food items have no hunger or saturation values

https://i.imgur.com/aduxR7b.png

Clientside Crash - Player Kicked From Server

[14:02:09] [Server thread/WARN] [minecraft/NetworkSystem]: Failed to handle packet for /192.168.1.7:55118
net.minecraft.util.ReportedException: Ticking player
at net.minecraft.entity.player.EntityPlayerMP.func_71127_g(EntityPlayerMP.java:459) ~[oq.class:?]
at net.minecraft.network.NetHandlerPlayServer.func_73660_a(NetHandlerPlayServer.java:173) ~[pa.class:?]
at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher$1.func_73660_a(NetworkDispatcher.java:209) ~[NetworkDispatcher$1.class:?]
at net.minecraft.network.NetworkManager.func_74428_b(NetworkManager.java:285) ~[gw.class:?]
at net.minecraft.network.NetworkSystem.func_151269_c(NetworkSystem.java:180) [oz.class:?]
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:790) [MinecraftServer.class:?]
at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:397) [nz.class:?]
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:668) [MinecraftServer.class:?]
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:526) [MinecraftServer.class:?]
at java.lang.Thread.run(Unknown Source) [?:1.8.0_191]
Caused by: java.lang.NullPointerException
at net.minecraft.util.FoodStats.func_151686_a(SourceFile:32) ~[afp.class:?]
at com.teammetallurgy.aquaculture.items.meta.SubItemFood.onEaten(SubItemFood.java:85) ~[SubItemFood.class:?]
at com.teammetallurgy.aquaculture.items.meta.MetaItemFood.func_77654_b(MetaItemFood.java:60) ~[MetaItemFood.class:?]
at net.minecraft.item.ItemStack.func_77950_b(ItemStack.java:222) ~[aip.class:?]
at net.minecraft.entity.EntityLivingBase.func_71036_o(EntityLivingBase.java:2781) ~[vp.class:?]
at net.minecraft.entity.player.EntityPlayerMP.func_71036_o(EntityPlayerMP.java:1125) ~[oq.class:?]
at net.minecraft.entity.EntityLivingBase.func_184608_ct(EntityLivingBase.java:2680) ~[vp.class:?]
at net.minecraft.entity.EntityLivingBase.func_70071_h_(EntityLivingBase.java:2090) ~[vp.class:?]
at net.minecraft.entity.player.EntityPlayer.func_70071_h_(EntityPlayer.java:234) ~[aed.class:?]
at net.minecraft.entity.player.EntityPlayerMP.func_71127_g(EntityPlayerMP.java:382) ~[oq.class:?]
... 9 more

Suggestion: AppleCore support

This mod should add support for AppleCore, so mods like Spice of Life can use diminishing returns on the items.

https://github.com/squeek502/AppleCore/wiki/Integrating-food-items-with-AppleCore

[1.11.2] Admin Rod doesn't reel properly

Forge 2282.
AQ Version 1.5.0.33

On use in water, the Admin fishing rod doesn't seem to retract at all, and requires either dropping or wielding a different item to cancel its cast. Right clicking just causes it to play the swipe animation, and it otherwise doesn't seem to respond to any kind of fish interaction.

[Config] Vanilla Rod/Mod Rods using our fishing system

Add a config option to change vanilla fishing rod to ours, which would allow mods that fish vanilla-style to fish up our fish.

Mounting

Reference photo:

A wooden plaque you can stick a fish on that when right clicked will display the species, weight of the fish, and date it was caught. Would just be the icon of the fish rendered onto the wall (or a new series of artwork could be made to be rendered against it) similar to an item frame. Scale of the icon to the wall could be based on weight to weight maximum.

Can't smelt Tin Cans in RLCraft

Unable to smelt Tin Can in RLCraft. Using the Just Enough Items mod it seems that the recipe doesn't work inside of RLCraft currently. Not sure if this is intended or a bug currently.

[Suggestion] Add potion recipes

At the moment, Aquaculture's Jellyfish does not have a use. Perhaps add a recipe that uses Jellyfish in it? Harvestcraft crafts Slime from Jellyfish, so that's a potential recipe.

Missing mcmod.info

Minecraft 1.11.2, Aquaculture 1.5.0

[Suggestion] Change Tin Can's smelting recipe when a mod adding the ingot is detected

Currently doing this through a script. Since tin cans are made of, well, tin, it would be nice if the mod changed the output of smelting a tin can from an iron ingot to a tin one, if it detects another mod registering a tin ingot. Probably checking for "ingotTin" oreDict existing should be a good enough check.

Suggestion: Support for Growthcraft and Harvestcraft fish traps

So we can catch all of the fish and items this mod has in fish traps from those mods

[1.11.2] Message In A Bottle Null Pointer Exception

Forge 2282, MC 1.11.2.

No crash persay, but on use of a message in a bottle, in chat it stated, for the message, 'Null Pointer Exception; Aquaculture.MessageInABottle (String) cannot be null.'

Sounds like it might not be the hardest fix, but, still worth reporting.

[Config] Disable fish weight

I would appreciate a config option to disable fish weight.
Why? So fish can be stackable of course!
Also, It'd make it much easier to use these fish with Crafttweaker Scripts.

[Configs] Weight NBT Tag Toggle

Normally the weight NBT tag prevents fish from stacking. The system is mostly aesthetic providing players with a little randomizer to catching fish but for some it might just be seen as inconvenient.

A toggleable config to disable it would be nice.

Might conflict with later plans (Advancements, Aquariums, Mounted Fish, etc.) that would use a weight system to determine size, but we can just use a default if they're disabled.

Way to disable specific junk items

I'm working on a survival modpack and want to prevent anything "modern" from being junk. Particularly tin cans and boxes.

[Configs] Tin Can Smelt

Due to its name and the prevalence of Tin in other mods. A Config option to change the smelting recipe to a choice of quantity and item name would be useful allowing server owners to choose what it smelts into instead of iron nuggets (or a less or more amount for their own internal balance.)

The hook renders above the water instead of resting in it

Expected behavior: Hook is in the water, bobbing up and down
Actual behavior: Hook is above the water, bobbing up and down. It only enters the water when there is a bite or when initially casting it into the water.
Aquaculture 1.5.0, Minecraft 1.11.2

[Mod Compatibility] Quark Visual damage values show up on fishing rods | 1.11.2

Heya,

if i'm using the Quark Visual Stats feature, the fishing rods display damage values and it overlaps with some information.

http://i.imgur.com/SSMdVYB.png

Wasn't sure which mod would have to "fix" this, but the vanilla, wooden and admin fishing rods don't have this issue, so i'm guessing it has something to do with how the iron/gold/diamond rods are setup?

Quark version: 1.2-89
Aquaculture version: 1.5.0.33

Also pinging @Vazkii

Let me know if i can provide anything that would help!

Thanks,
SC

[Feauture] Box Loot

Pop up some text , preferably action bar , on what you got out of the lootboxes you can fish. i keep looking for what it might be, and I had 2 so far, but with a full inventory I can't tell if I just got a stick more, an arrow, or a dandelion that is in my inventory that I may have picked up exploring around. i cant remember...

some info would be nice !

Crash - Eating any Aquaculture food (AppleCore)

Minecraft - 1.12.2
Forge - 14.23.4.2707
Aquaculture - 1.6.4
Apple Core - 3.1.1
Apple Skin - 1.0.9

Having a bit of a problem when eating any type of food added by this mod. It seems to be a problem with Apple Core/Skin, or that's what i think.

Crash-Log

I don't know if it is compatibility problems or is just me, but would appreciate some help.

Fishing in non-vanilla biomes == uh oh

MC 1.12.2
Forge 14.23.4.2715
Aqua 1.6.5

When I fish in a vanilla biome, the rods work as expected. When I fish in a non-vanilla biome, such as BoP or Thaum's magical place, the first click doesn't seem to want to respond and a second click causes the below error in the console. Happens in SP and server.

[17:44:09] [Server thread/FATAL] [minecraft/MinecraftServer]: Error executing task
java.util.concurrent.ExecutionException: java.lang.NullPointerException
at java.util.concurrent.FutureTask.report(Unknown Source) ~[?:1.8.0_172]
at java.util.concurrent.FutureTask.get(Unknown Source) ~[?:1.8.0_172]
at net.minecraft.util.Util.func_181617_a(SourceFile:47) [h.class:?]
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:723) [MinecraftServer.class:?]
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:668) [MinecraftServer.class:?]
at net.minecraft.server.integrated.IntegratedServer.func_71217_p(IntegratedServer.java:185) [chd.class:?]
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:526) [MinecraftServer.class:?]
at java.lang.Thread.run(Unknown Source) [?:1.8.0_172]
Caused by: java.lang.NullPointerException
at com.teammetallurgy.aquaculture.loot.BiomeType.getBiomeType(BiomeType.java:46) ~[BiomeType.class:?]
at com.teammetallurgy.aquaculture.loot.FishLoot.getRandomJunk(FishLoot.java:90) ~[FishLoot.class:?]
at com.teammetallurgy.aquaculture.handlers.EntityCustomFishHook.func_146034_e(EntityCustomFishHook.java:506) ~[EntityCustomFishHook.class:?]
at com.teammetallurgy.aquaculture.items.ItemAquacultureFishingRod.func_77659_a(ItemAquacultureFishingRod.java:70) ~[ItemAquacultureFishingRod.class:?]
at net.minecraft.item.ItemStack.func_77957_a(ItemStack.java:217) ~[aip.class:?]
at net.minecraft.server.management.PlayerInteractionManager.func_187250_a(PlayerInteractionManager.java:358) ~[or.class:?]
at net.minecraft.network.NetHandlerPlayServer.func_147346_a(NetHandlerPlayServer.java:763) ~[pa.class:?]
at net.minecraft.network.play.client.CPacketPlayerTryUseItem.func_148833_a(SourceFile:32) ~[mb.class:?]
at net.minecraft.network.play.client.CPacketPlayerTryUseItem.func_148833_a(SourceFile:9) ~[mb.class:?]
at net.minecraft.network.PacketThreadUtil$1.run(SourceFile:13) ~[hv$1.class:?]
at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) ~[?:1.8.0_172]
at java.util.concurrent.FutureTask.run(Unknown Source) ~[?:1.8.0_172]
at net.minecraft.util.Util.func_181617_a(SourceFile:46) ~[h.class:?]
... 5 more

Late enchantment registration

As of 1.12.2-1.6.8, the mod appears to register enchantment later than expected according to Apotheosis-1.12.2-1.10.2 logs:

[19:02:43] [Server thread/ERROR] [Apotheosis : Enchantment]: Had to late load enchantment info for aquaculture:appealing, this is a bug in the mod aquaculture as they are registering late!
[19:02:43] [Server thread/ERROR] [Apotheosis : Enchantment]: Had to late load enchantment info for aquaculture:magnetic, this is a bug in the mod aquaculture as they are registering late!
[19:02:43] [Server thread/ERROR] [Apotheosis : Enchantment]: Had to late load enchantment info for aquaculture:long_cast, this is a bug in the mod aquaculture as they are registering late!
[19:02:43] [Server thread/ERROR] [Apotheosis : Enchantment]: Had to late load enchantment info for aquaculture:short_cast, this is a bug in the mod aquaculture as they are registering late!
[19:02:43] [Server thread/ERROR] [Apotheosis : Enchantment]: Had to late load enchantment info for aquaculture:double_hook, this is a bug in the mod aquaculture as they are registering late!
[19:02:43] [Server thread/ERROR] [Apotheosis : Enchantment]: Had to late load enchantment info for aquaculture:barbed_hook, this is a bug in the mod aquaculture as they are registering late!
[19:02:43] [Server thread/ERROR] [Apotheosis : Enchantment]: Had to late load enchantment info for aquaculture:heavy_line, this is a bug in the mod aquaculture as they are registering late!

High level Short Cast casts further than low level

Unintuitively, Short Cast I casts the shortest, while Short Cast V cast much further than Short Cast I (but still lower than no Short Cast). It would seem more logical to have higher levels of Short Cast have a stronger effect on the rod (as in cast it shorter with a higher level) instead of the opposite.