Giter Site home page Giter Site logo

Comments (6)

kiraarghy avatar kiraarghy commented on May 20, 2024 1

@parkerziegler

  • Agree with the folder structure and namespacing, thanks for explaining!
  • I generally prefer pascal case cause snake case brings up memories of my bad python code 🐍. It feels more Reason/OCaml-esque TBH.

from rescript-urql.

kiraarghy avatar kiraarghy commented on May 20, 2024

I'll take this!

from rescript-urql.

parkerziegler avatar parkerziegler commented on May 20, 2024

Dope! Assigning you now. I'll probably take Mutation so we can each take a stab at our own approaches and see where we land relative to one another.

from rescript-urql.

parkerziegler avatar parkerziegler commented on May 20, 2024

FYI @kiraarghy let's copy the folder structure from urql exactly. So for the Query component, let's put it in src/components/UrqlQuery.re and for the hook let's put it in src/hooks/UseQuery.re or something of that sort. Why the weird naming for UrqlQuery? Well, one thing I've thought about is that consumers of reason-urql might have their own Query module somewhere in the tree, with which a Query module might collide. So by namespacing it: http://2ality.com/2017/12/modules-reasonml.html#namespacing-modules, we prevent these potential collisions. In our top level ReasonUrql.re we'll just alias them to their true names, i.e.

/* ReasonUrql.re */
module Query = UrqlQuery

I'd also be curious about using snake case for modules rather than pascal case. I know Wonka uses snake case 🤔 Any feelings or opinions here? What reads to you as more Reason-y?

from rescript-urql.

parkerziegler avatar parkerziegler commented on May 20, 2024

Cool! Let's stick with pascal case! 🚀 🚫 🐍

from rescript-urql.

parkerziegler avatar parkerziegler commented on May 20, 2024

Let's not worry about useQuery right now. Until ReasonReact gets support for hooks, I'm leery of trying to do any sort of hacking to support this.

from rescript-urql.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.