Comments (6)
- Agree with the folder structure and namespacing, thanks for explaining!
- I generally prefer pascal case cause snake case brings up memories of my bad python code 🐍. It feels more Reason/OCaml-esque TBH.
from rescript-urql.
I'll take this!
from rescript-urql.
Dope! Assigning you now. I'll probably take Mutation
so we can each take a stab at our own approaches and see where we land relative to one another.
from rescript-urql.
FYI @kiraarghy let's copy the folder structure from urql
exactly. So for the Query
component, let's put it in src/components/UrqlQuery.re
and for the hook let's put it in src/hooks/UseQuery.re
or something of that sort. Why the weird naming for UrqlQuery
? Well, one thing I've thought about is that consumers of reason-urql
might have their own Query
module somewhere in the tree, with which a Query
module might collide. So by namespacing it: http://2ality.com/2017/12/modules-reasonml.html#namespacing-modules, we prevent these potential collisions. In our top level ReasonUrql.re
we'll just alias them to their true names, i.e.
/* ReasonUrql.re */
module Query = UrqlQuery
I'd also be curious about using snake case for modules rather than pascal case. I know Wonka uses snake case 🤔 Any feelings or opinions here? What reads to you as more Reason-y?
from rescript-urql.
Cool! Let's stick with pascal case! 🚀 🚫 🐍
from rescript-urql.
Let's not worry about useQuery
right now. Until ReasonReact gets support for hooks, I'm leery of trying to do any sort of hacking to support this.
from rescript-urql.
Related Issues (20)
- manually running queries creates memory leak HOT 4
- Working with Upload types HOT 2
- [Umbrella] reason-urql v2 Refactors & Improvements HOT 4
- upgrade urql version HOT 3
- Runtime error "value is null" with the latest Reason Urql version HOT 7
- Few mistakes in doc HOT 3
- TypeError: state.talkback is not a function HOT 8
- Client.executeQuery will "reset" all the default values of client HOT 1
- Adopt `graphql-ppx` 1.0 HOT 20
- urql shouldn't be a dep but a peer dep HOT 5
- Running to an error with wonka HOT 2
- useDynamicMutation hook: Getting an error for returned executeMutation function with no variables HOT 2
- TypeError: b is not a function HOT 13
- Migrate documentation code samples to ReScript.
- Rename package to rescript-urql HOT 1
- Two questions related to testing HOT 5
- Using @rescript/react HOT 3
- Provide a method to get GraphQLError as Js.Exn.t HOT 2
- Error while running external preprocessor HOT 3
- Headers not added to request when using with HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rescript-urql.