tedd/tedd.spanutils

Utilities for reading/writing to Span<byte>

tedd.spanutils's Issues

SpanStream : Length is set to 0 initially ?

This looks strange?

I would expect the length to be 3?

The TargetFrameworks doesn't need to include all frameworks, just add the minimum

Change this

<TargetFrameworks>net461;net462;net47;net471;net472;net48;netstandard2.0;netstandard2.1;netcoreapp3.1;net5.0</TargetFrameworks>

Into

<TargetFrameworks>net461;netstandard2.0;netstandard2.1</TargetFrameworks>

Info:

• net461 is the lowest framework, and can be used by net462 net47 net471 net472 net48
• netstandard2.0 --> This can be used by net471 and higher, and off course by netcoreapp2.x, 3.x and net5.0
• netstandard2.0 --> This can be used by netcoreapp3.x and net5.0 (it's not really needed to provide this one, but my personal preference is to include this one also)

Benchmark integer copying

Benchmark different ways to copy into Span. Different techniques result in different opcodes. Some with many branches. Also writing last byte first to span causes all consecutive overflow checks to be removed. But chances are we will cross cache lines in reverse order. Benchmark, benchmark benchmark.

https://sharplab.io/#v2:C4LghgzgtgPgAgJgIwFgBQcAMACOSB0ASgK4B2wAllAKb4CS51ATgPYAOAyswG4UDG1CAG506OAGZcCbAGFsAb3TZluSXAAs2ALIAKAJQKlKgL5HlE7GQhgAZtVyaA6kwrBqAFUHAkOjmzCkADwARgCebgB82BD+pAA02BTk2NxgADbE1Hpmhmgq+dgA9IXa1FAsTKFaYEwQABbp0bb2fJDAOfl+AYFJwFFg2AC80cBgfADW6WksfInkANpIALoKqRnUxiJ5BcqpTNhgwUOl5ZXVtQ1p+DJtPeQJYZE6YHpbO8qH1+yh7iw6MQFXjlTNtlDkLBpsM5XB4vAhfLEQuFqFEAfE5sAUulMtlQbl3kUSgAhZHYMJk0l8b4dFRo+biFbDHSPLJrTJCAn5GnKOkIRnYZnIvQ6Nn2CJRHQADmwACpsEg9EC8fk6ctjoK3MLRdhxQLpXKEIq3u86Zh+RqsiLsWKJfrsOIjcDsKI8RYrM0HFCXG5PBBgOIEd0WajYglelj1rj8oplSpitguqRsMAWNFYtgqWxQtgAO6uOqWUjWOwZtrJ1No7kYuVHYZ+saTNLTWa9RYreQRzLYTZVvbRY6kag5hOI4M6HQaGV6YIJCAUABe1BYNh0vUdsZ5Xyzv3+sSV+WMzrx4Mk7pLkOhPq86kDQWDaYCYeSoqjKhjBPjJLcFIp38z2ZsVgoGwcZSBYHMkznRcABMRgbA4mCYMBQl7GoyWOesJimGZf2oeZ2yPTkVAtLVrR1W1ZXtRU4irfISKtdZyL1SjDT0GiNwKejtV1KVKIVNjaOIlk9FFKsew401+WCeYzWNHZVSkts5IKXlFL5ZSVVielFIZZTDxdfI3SLD0L29WE/QAVlvJFIgfdFwxfHJ33eT9SXJFkM2+bBAJYYCzxaNpqFgzDxgQpCUI43o5QoDDRiwpscNbdttXEgk+1rAUWSnCgNNpLSzWOaTZKrBTCqUkqtL5Mr1IqgJtLK3SnRdYwgA==

.netstandard 2.0

Can you please make your library compatible with .net standard 2.0 ?

More datatypes

• Bool
• Char
• Char-array
• Float
• Double
• Decimal
• DateTime
• TimeSpan?
• BitArray?

Optimize float, double and decimal

Benchmark if current method is the optimal.

https://sharplab.io/#v2:C4LghgzgtgPgAgJgIwFgBQcAMACOSB0ASgK4B2wAllAKb4CS51ATgPYAOAyswG4UDG1CAG506OAGZcCbAGFsAb3TZluSXAAs2ALIAKAJQKlKgL5HlE7GQhgAZtVyaA6kwrBqAFUHAkOjmzCkADwARgCebgB82BD+pAA02DYANixgwNjcYEnE1HpmhmgqRdgA9CXa1FAsTKFaYEwQABZZ0bb2fJDA+UV+AYHJqcBRYNgAvNHAYHwA1lkpfIkpaQDaSAC6CpnZ1MYihcXKmUzYYMFjFVU1dQ3NSfgynf1LwAlhkTpgensHyqf37KF3CwdDEAl98qZ9sp8hYrG0HNhnK4PF4EL5YiFwtQoqD4otBhksjk8lCCj9SuVeqRsMAWNFYtg+ADsAB3VyNSykax2RmdGl03HdFQDNIAKmwZ3GEEmMzmLAWIuAqw28kJ22wuyFh3q0XOpGoLOwVMx7x0GlFemCCQgFAAXtQWDYdIq9ODSUUIP82IDgbi3UVjNh8jDJHCeRpES43J5peJ0X03tj6QEEoq1cT8op3SoytgAEJYiWhItuRnMmysKCc7ntTrUAAmEym0xOTCYYFCWvxYuwFHO0ubcoVz2WKq2OQ13x+Rwl5x0iYtFCnB1xy0wG3GwTXa2XxVX63OW/Wu49sWWCA3EvPO67q/El63993gdEaGMQA===

SpanStream v.s. BinaryReader & BinaryWriter

Hello @tedd ,

I thought that the SpanStream could be used to replace BinaryReader and BinaryWriter, however this does not work because the byte storing is reversed.

Your code

public static UInt32 ReadUInt32(this Span<byte> span)
        {
            // return MemoryMarshal.Cast<byte, UInt32>(span)[0];
            return (UInt32)(
                ((UInt32)span[3])
                | ((UInt32)span[2] << (8 * 1))
                | ((UInt32)span[1] << (8 * 2))
                | ((UInt32)span[0] << (8 * 3))
                );
        }

Code from BinaryReader (https://referencesource.microsoft.com/#mscorlib/system/io/binaryreader.cs,185)

return (int)(m_buffer[0] | m_buffer[1] << 8 | m_buffer[2] << 16 | m_buffer[3] << 24);

Is this intentional?

MoveReadShort and MoveReadUShort are missing?

Question: are the VLQ methods compatible with the VINT from the EBML spec?

Are these compatible?

See this document which describes the VINT:
https://github.com/ietf-wg-cellar/ebml-specification/blob/master/specification.markdown#variable-size-integer

Short, UShort, Int, UInt, Long, ULong aliases

Add aliases for known datatypes

SpanStream : ReadByte returns an int ?

Tedd.SpanUtils/src/Tedd.SpanUtils/SpanStream.cs

Line 394 in a6c71f9

public int ReadByte()

I think this should be byte ?