The amrenc from teknoraver

amrenc's Introduction

Ciao 👋🏻

I'm (trying to be) a Linux kernel developer, working for @facebook (formerly Microsoft, Red Hat and Canonical).
I've been using Linux since 2003, my favourite distros are Debian and Fedora, and KDE Plasma is my desktop of choice.

I'm a big open source supporter, so I contribute to OSS projects whenever possible.
To name a few: Linux, systemd, OpenWrt, iproute2, Snap, Open vSwitch, RPM, u-root, SANE, BusyBox, and lots of small fixes and PRs here and there... 🙂

Despite my efforts to contribute to science, my most recognized works are April fools:

or silly sound generating scripts, e.g. perl -e 'for($t=0;;$t++){print chr($t*($t>>8|$t>>13)&255)}' |aplay (replace | with & for an alternate version)

amrenc's People

Contributors

Stargazers

Watchers

amrenc's Issues

divide-by-zero in main (amrenc.c)

On 0.5.3:

# amrenc $FILE out.amr
===================================================================
 3GPP AMR Floating-point Speech Encoder  REL-7 V7.0.0 2007-06      
===================================================================
ASAN:DEADLYSIGNAL
=================================================================
==24102==ERROR: AddressSanitizer: FPE on unknown address 0x000000508bc7 (pc 0x000000508bc7 bp 0x7ffcecf32a40 sp 0x7ffcecf32980 T0)
    #0 0x508bc6 in main /tmp/amrenc/amrenc.c:155:33
    #1 0x7f948a96e680 in __libc_start_main /var/tmp/portage/sys-libs/glibc-2.23-r4/work/glibc-2.23/csu/../csu/libc-start.c:289
    #2 0x419b18 in _start (/usr/bin/amrenc+0x419b18)

AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: FPE /tmp/amrenc/amrenc.c:155:33 in main
==24102==ABORTING

Testcase attached
testcase.zip

some undefined behavior issues

On 0.5.3, compiled with -fsanitize=undefined:

# amrenc $FILE out.amr                                                                                                                                      
===================================================================                                                                                                                                               
 3GPP AMR Floating-point Speech Encoder  REL-7 V7.0.0 2007-06                                                                                                                                                     
===================================================================                                                                                                                                               
sp_enc.c:3472:12: runtime error: index -28 out of bounds for type 'Float32 [40]'                                                                                                                                  
SUMMARY: AddressSanitizer: undefined-behavior sp_enc.c:3472:12 in                                                                                                                                                 
sp_enc.c:7225:29: runtime error: left shift of negative value -2                                                                                                                                                  
SUMMARY: AddressSanitizer: undefined-behavior sp_enc.c:7225:29 in                                                                                                                                                 
sp_enc.c:7232:27: runtime error: left shift of negative value -273815                                                                                                                                             
SUMMARY: AddressSanitizer: undefined-behavior sp_enc.c:7232:27 in                                                                                                                                                 
sp_enc.c:7149:21: runtime error: left shift of negative value -9208320
SUMMARY: AddressSanitizer: undefined-behavior sp_enc.c:7149:21 in 
[100%]

The issues are reproducible with each wav file.

Recommend Projects