telepathyim/ktp-common-internals

Library for KTp

ktp-common-internals's Issues

MessagesModel: Implement check for messages duplication

"Clients wishing to determine whether a new message with the scrollback header matches a previously-logged message with the same message-token SHOULD compare the message's sender, contents, message-sent or message-received timestamp, etc. Note that, in XMPP, the server only supplies a timestamp for scrollback messages, not for messages received while you are in a room; thus, non-scrollback messages will lack a message-sent timestamp."

Implement Channel Interface MessageArchive support

Implementation for the interface in KTp/Logger/scrollback-manager can be as trivial as:

diff --git a/KTp/Logger/scrollback-manager.cpp b/KTp/Logger/scrollback-manager.cpp
index d9680ae..8f3ab43 100644
--- a/KTp/Logger/scrollback-manager.cpp
+++ b/KTp/Logger/scrollback-manager.cpp
@@ -105,11 +105,15 @@ void ScrollbackManager::fetchHistory(int n)
 {
     if (n > 0 && !d->account.isNull() && !d->textChannel.isNull()) {
         if (d->contactEntity.isValid()) {
-            KTp::LogManager *manager = KTp::LogManager::instance();
-            KTp::PendingLoggerDates *dates = manager->queryDates(d->account, d->contactEntity);
-            connect(dates, SIGNAL(finished(KTp::PendingLoggerOperation*)),
-                    this, SLOT(onDatesFinished(KTp::PendingLoggerOperation*)));
-            return;
+            if (d->textChannel->hasArchiveInterface()) {
+                d->textChannel->getMessages();
+            } else {
+                KTp::LogManager *manager = KTp::LogManager::instance();
+                KTp::PendingLoggerDates *dates = manager->queryDates(d->account, d->contactEntity);
+                connect(dates, SIGNAL(finished(KTp::PendingLoggerOperation*)),
+                        this, SLOT(onDatesFinished(KTp::PendingLoggerOperation*)));
+                return;
+            }
         }
     }

But, it would be much better to implement a proper plugin with KTp::AbstractLoggerPlugin inheritance.

Conversation does not check if account is nullptr

I seem to have a somewhat messed up setup were AccountManager returns a nullptr for /org/freedesktop/Telepathy/Account/ring/tel/account0

MainLogModel::processQueryResults as well as Conversation both do not check the value of account and it therefore crashes later on

(this is mainly a note to myself, remind me if it gets stale ...)