Giter Site home page Giter Site logo

teleport-lib-js's People

Contributors

alexnm avatar alexpausan avatar crissmoldovan avatar ionutpasca avatar timoftean avatar utwo avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

teleport-lib-js's Issues

`use` method is error prone in its current format

The use of use method is error prone: if you forget to call with wrapped with async/await the libraries are not loaded properly.

Proposal: remove readPluginDefinitionFromUrl from it and make it sync. Keep readPluginDefinitionFromUrl as a standalone method.

should we allow the use of void elements as root element of a Component?

In the case of Next.js for example, an component with a root element img will trigger a React error because of the attempte to insert the <style jsx> tag as child of the <img> tag.

To avoid this error, we could check for the type of element rendered, and if it is a root and void element we could insert the style data inline.

Component, Page and Content type definitions do not match the teleport api format

export interface Page {
  name: string
  content: Content
  url?: string
  children?: Component[] | string //Page api does not contain children
}

export interface Component {
  name: string
  content: Content
  children?: Component[] | string //Component does not contain children
  editableProps?: {
    [key: string]: ComponentEditableProp
  }
}

export interface Content {
  type: string
  source: string
  name: string
  style: {
    [key: string]: string
  }
// Content contains children 
}

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.