telerik-verified-plugins/securehttp

Cordova / Phonegap plugin for communicating with HTTP servers. Allows for SSL pinning!

securehttp's Issues

client cert?

Hello there, is it possible to use this plugin to work with client certificates? My app won't know the certificate that needs to be accepted, so I can't really store any certificates in my root/assets folder.
As of today, any sites that need client certificates don't work on iOS or Android devices using cordova - they work well using regular browsers though.

Issue with POST requests

We are using this plugin to enable SSL-Pinning in a Ionic 2 enviroment. Unfortunately the POST-requests fail with JSON-parse error on the serverside. When I JSON.stringify the body it also doesn't work since an object is expected.

Did anybody else have similar issues?

Cordova CLI: 6.5.0
Ionic Framework Version: 2.0.0
Ionic CLI Version: 2.2.1
Ionic App Lib Version: 2.2.0
Ionic App Scripts Version: 1.1.4
ios-deploy version: 1.9.1
ios-sim version: Not installed
OS: macOS Sierra
Node Version: v7.6.0
Xcode version: Xcode 8.3.2 Build version 8E2002

Thanks for the help.

com.telerik.afnetworking offline

The plugin cannot be installed because npm package com.telerik.afnetworking is offline

Error: Failed to fetch plugin com.telerik.afnetworking via registry.
Probably this is either a connection problem, or plugin spec is incorrect.
Check your connection and plugin name/version/URL.
Error: Registry returned 404 for GET on https://registry.npmjs.org/com.telerik.afnetworking

error: package org.apache.cordova.file does not exist

Can't seem to get this to build on android.

:compileDebugJava/Users/admin/Projects/test-app/client/platforms/android/src/com/synconset/CordovaHttpDownload.java:20: error: package org.apache.cordova.file does not exist
import org.apache.cordova.file.FileUtils;
                              ^
/Users/admin/Projects/test-app/client/platforms/android/src/com/synconset/CordovaHttpDownload.java:48: error: cannot find symbol
                JSONObject fileEntry = FileUtils.getEntry(file);
                                       ^
  symbol:   variable FileUtils
  location: class CordovaHttpDownload
Note: Some input files use or override a deprecated API.

Cordova CLI: 5.4.0
Gulp version:  CLI version 3.9.0
ios-deploy version: 1.8.2 
ios-sim version: 5.0.3 
OS: Mac OS X El Capitan
Node Version: v5.0.0
Xcode version: Xcode 7.1 Build version 7B91b 

I tried installing the latest cordova-file-plugin but I'm still getting this error. Maybe it has something to do with gradle?

Is "PATCH" method supported?

Is "PATCH" method supported? If no, is there a plan to support it?

How to validate if the plugin is working fine for me?

So sorry to create an issue for this. But how are your guys validating that the plugin is working fine for you?

Abort?

As the title suggests, I would like to know if it's easy to add an abort method for the request? I'm not an objective-c or java expert though.

ios 8/9, non trusted request are executed

I'm using the plugin with android and iOS 8/9
After copying the certificates in the www/certificates folder and in the proper platform directory (just to be sure) and enabling ssl pinning in android i can see all the request to not trusted domain blocked. In iOS every request is allowed and served.

How can one POST application/json with this?

I have been trying to use this plugin to post jsons to a REST api, I simply can't.

It always sends as application/x-www-form-urlencoded and tries to parse my json into params.

eg:

{
"id":1,
"name": "John Doe"
 }

becomes: id=1&name=John+Doe

android: acceptAllCerts doesn't call callbacks

As per API/doc, acceptAllCerts should call one of its success/failure callback but it's not doing so. At least on android, the CordovaHttpPlugin's execute method is not calling success()/error() on callbackContext for the "acceptAllCerts" as it is doing for the "enableSSLPinning" case.

iOS doesn't compile because of a missing framework

My iOS8 project did not compile until I added the SystemConfiguration.framework framework.

Client Certificate Authentication?

@EddyVerbruggen - since you have forked this plugin and made it more specific to being a secure http plugin, would you be interested in client certificate authentication so it can handle mutual auth, not just pinning?

I have added it to my fork of cordova-HTTP and could make a PR for here, then just use this one instead.

Only happening on iOS, but returns 400?

this URL returns to be valid, but with AFNetworking, it returns as 400

http://ciapi.cityindex.com/TradingApi/clientapplication/versioninformation?AppKey=iPhone

any idea?

Add PUT and DELETE to return a promise

Thanks for adding PUT and DELETE method.

We are currently using this plugin with Cordova and Angular1, Can you please modify the "cordovaHTTP.js" file to return a promise for PUT and DELETE method.

Thanks

compile error in iOS: 'Cordova/CDVJSON.h' file not found

  'Cordova/CDVJSON.h' file not found

import <Cordova/CDVJSON.h>

This is using Cordova 6.2.0. Removing this statement in CordovaHttpPlugin.h compiles, is this being used?

Allow loading certificates from within the www folder

Typically Cloud-based IDE's do not allow you to add .cer files in the places supported by this plugin.

We should add the possibility to add certificates to a folder like www/certificates.

HTTP PUT method

Hey!

Nice Plugin, but why is there no PUT or DELETE HTTP method?

Thank you!
Kirrg

Generic Error Messages in iOS

When my server returns error, the body is a jSON object of the error details. In android, this comes through fine, but in iOS, it's simply coming back as a detail of whatever error code i pass. So when I pass a 400 with error details, iOS returns "Request failed: bad request (400)." The library should still show the data from the response even though it is an error.

Clobber XMLHttpRequest

Currently the plugin requires a brand new Http API to be used instead of familiar ones like jQuery's Ajax or Angular's $http.It would be great if this plugin clobbers the root XMLHttpRequest so that everything works out of the box

missing command error

window.cordovaHTTP.get(
  "https://platform.telerik.com",
  {}, // optional params
  {}, // optional headers
  function(msg) {alert("OK: " + msg)},
  function(msg) {alert("ERROR: " + msg)}
);

msg: missing command error

Can someone tell me what's going on?