telosnetwork/app-telos-net

app-telos-net's Issues

Reduce number of wallet options

The only option for wallet should be Anchor for both mobile and desktop

Showing wrong value when creating a ballot

When creating a ballot, the fee is shown as 100000 instead of 10. It would also be good to specify that we're showing the value in TLOS and not USD or some other currency/token.

To consider:
Remove the regex function and show 10.0000 TLOS.

Time indicator is misplaced on mobile

When using a mobile size viewport, the div containing time and status is misplaced on top of other information. The image below shows the issue with an iPhone SE viewport size.

This is reproducible with viewport width of 1000px or less

upgrade/fix/check all packages listed in the dependabot alerts

All packages need to be checked in order to avoid known exploits

Treasuries option in the ballot creation form needs to filter the options

The getter for those options is here:

app-telos-net/src/pages/trails/ballots/components/ballot-form.vue

Line 47 in 7e36abb

...mapGetters('trails', ['treasuries']),

An account can only create ballots in treasuries which it is registered for, as seen in the contract code where it looks up the tables:

https://github.com/telosnetwork/telos-decide/blob/22e300dd50db6709dc0d5115894dbc611b09a690/contracts/decide/src/ballot.cpp#L23

So, that getter needs to also filter where the current account is a voter. Likely can do a lookup on the voters table and only show the treasuries you find there, similar to how the actual contract does the table lookup.

Confirmation dialog for ballot fee

Description

Currently, when the user opens a ballot, there is no indication that there is a fee associated with opening it. Before the user gets an error message or they're surprised by their reduced balance, we want to show them they'll be paying the fee.

The expected flow

1. User clicks new ballot
2. User fills out ballot
3. User clicks create
4. New dialog/modal confirms they accept the fee
5. We send the transactions for ballot creation

Acceptance criteria

• Dialog/modal appears when user clicks the create button
• Dialog/modal shows the fee that will be paid
• Dialog/modal shows Cancel and Accept options
• Dialog/modal shows that user doesn't have enough funds when they don't have enough funds

Properly configure ballots for votestake/voteliquid

When creating a ballot, we should never create a ballot where votestake and voteliquid are both false, because then there will never be any vote weights to count, and voting will always fail with the "must vote with a positive amount" error.

When creating a ballot, voteliquid is always set to false and votestake is always set based on the stakeable value from the treasury's settings:

https://github.com/telosnetwork/telos-decide/blob/22e300dd50db6709dc0d5115894dbc611b09a690/contracts/decide/src/ballot.cpp#L51

So, if a treasury's token is not stakable, we always should toggle voteliquid to true... which is the case for the VOTE token, this is why those ballots we have created for testing will never get votes. If a treasury's token is stakable, we should give the user an option in the form "Would you like to count liquid or staked or both"... but we cannot ever submit a ballot with both of those values set to false (which is what ballots for the VOTE token currently do). Maybe a message would be good in any case... "This treasury is not stakeable so liquid tokens will be used" or "This treasury is stakable, would you like to count liquid or staked tokens, or both?"

The settings should be on the treasury row, which I think should be loaded into the store already. So you can check the value of the stakeable property on the treasury row's settings to see how to handle this on the ballot form.

To toggle ballot settings, we need to call the togglebal action:

https://github.com/telosnetwork/telos-decide/blob/22e300dd50db6709dc0d5115894dbc611b09a690/contracts/decide/src/ballot.cpp#L100

To call that action, we need to add another action to the array of actions we create in the addBallot function here:

app-telos-net/src/store/trails/actions.js

Line 145 in 7e36abb

const actions = [

To know what values the ballot will have for each setting, see the code in ballot.cpp above... voteliquid is always starting as false, and votestake is based on the stakeable setting, so based on that logic, and what the user has selected, need to toggle one or both of those settings by adding 1 or 2 actions to the actions array in addBallot function.

Remove the "Fake data"

Find where it comes from and remove it, it looks like it is hardcoded.

Better display of ballot end time

On the ballot view, for already created ballots, if a ballot ended, we should show when it ended. Or if it is still in progress, we should show when it will end.

Ensure there are 2 options at least for a ballot

Should ensure there are at least 2 options, I believe another failure we saw was when attempting to create a ballot with only one option.

Improve error handling on failed transaction

Show the actual error from the contract, without the assertion prefix (details[0]):

{
    "code": 500,
    "message": "Internal Service Error",
    "error": {
        "code": 3050003,
        "name": "eosio_assert_message_exception",
        "what": "eosio_assert_message assertion failure",
        "details": [
            {
                "message": "assertion failure with message: ballot name already exists",
                "file": "cf_system.cpp",
                "line_number": 14,
                "method": "eosio_assert"
            },
            {
                "message": "pending console output: ",
                "file": "apply_context.cpp",
                "line_number": 143,
                "method": "exec_one"
            }
        ]
    }
}

get_table_rows calls continue forever

When leaving the website open on the ballots page, get_table_rows continues to get called, causing unnecessary resource usage on the user's computer.