Comments (5)
I make the assumption that most use a 16px
root and the icons are 24dp
at native 1:1 screens. So as you saw I apply scaling of 1
as 1.5rem
(style="width: 1.5rem"
).
Since 99% of users are using these along with themes where 16px is the norm I think it might be best to keep this and let users override it with CSS.
I went back and forth on this, but will probably be following this in the Angular and VueTS components.
Are you using the icons at a smaller than 24px size?
from materialdesign-react.
Oh, I see.
Here are some examples on my website: https://azdanov.js.org/blog (WIP).
In menu larger, in meta information for posts smaller, and footer also small.
from materialdesign-react.
Yea, that kind of works, but I'm on a Surface Pro, so they look good on these high resolution displays).
For smaller icons you could just do <Icon path={mdiTag} size="1em"/>
, or override it in CSS.
At work I'm mostly using <Icon size={1.5}/>
for 36px
, and <Icon size={2}/>
for 48px
. But I'm still targeting a lot of users on 1:1 displays.
from materialdesign-react.
I didn't know about size="1em"
. This resolves this issue for me.
Thanks!
from materialdesign-react.
Made it one of the unit tests:
https://github.com/Templarian/MaterialDesign-React/blob/master/tests/Icon.spec.tsx#L57
from materialdesign-react.
Related Issues (20)
- How do you dynamically load an Icon? HOT 14
- Invariant Violation HOT 8
- Icon prop types do not allow assignment of onClick HOT 4
- Icon is using deprecated SFC type instead of FunctionComponent type HOT 1
- [Feature request] Add default class attribute to all svg elements HOT 2
- Dynamic load icons HOT 1
- Why '--save-dev'? HOT 1
- Icon path prop not accepting strings? HOT 1
- Incremented `id` doesn't play nicely w/ SSR HOT 9
- Add 'prop-types' as a dependency (or remove it) HOT 4
- Baseline flag HOT 1
- Change/Disabled role in svg icon HOT 1
- `spin` broken in Safari HOT 5
- Build error HOT 8
- Cannot assign to read only property 'width' of object '#<Object>' icon HOT 1
- add a view-box prop HOT 1
- Can't use 'onClick' on Icon in Typescript HOT 1
- Different styles of icons (rounded, sharp, outlined)
- Does this library still need to be maintained?
- Default import of Icon crushes production build HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from materialdesign-react.