Giter Site home page Giter Site logo

Comments (4)

chubei avatar chubei commented on May 11, 2024 1

PR submitted. I'm new to github. My apologies if anything went wrong.

from tensorly.

gudovskiy avatar gudovskiy commented on May 11, 2024 1

Chubei, thanks for the finding!

from tensorly.

JeanKossaifi avatar JeanKossaifi commented on May 11, 2024

I agree. I usually need less eigenvalues than the maximal rank of the matrix and therefore do not default on the actual svd when using partial_svd, so I haven't dealt with this issue.

However this is probably a good change to make: would you like make a small pull request with the changes you suggest?

from tensorly.

JeanKossaifi avatar JeanKossaifi commented on May 11, 2024

Fixed by #7.

from tensorly.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.