terrykemp/sailcast-podcast

SailCast is a basic app to create your favorite podcast. It is still very much in its infancy stages.

sailcast-podcast's Issues

Move this up!

Keep this near the top with the rest of your configuration

SailCast-podcast/index.js

Line 90 in 5ec8758

app.use(express.static(`${__dirname}/public`))

Delete dead code! ☠

Commented out code is called Dead Code - just delete it!

SailCast-podcast/config/passport.js

Lines 1 to 43 in 5ec8758

	// const passport = require('passport')
	// var LocalStrategy = require('passport-local').Strategy
	// var User = require('../models/user')
	// module.exports = function (passport) {
	// passport.use('local-signup', new LocalStrategy({
	// usernameField: 'email',
	// passwordField: 'password',
	// passReqToCallback: true
	// })),
	// function (req, email, password, callback) {
	// // Find a user with this e-mail
	// User.findOne({
	// 'local.email': email
	// }, function (err, user) {
	// if (err) return callback(err)
	// // If there already is a user with this email
	// if (user) {
	// return callback(null, false, req.flash('signupMessage', 'This email is already used.'))
	// } else {
	// // There is no email registered with this email
	// // Create a new user
	// var newUser = new User()
	// newUser.local.email = email
	// newUser.local.password = newUser.encrypt(password)
	// newUser.save(function (err) {
	// if (err) throw err
	// return callback(null, newUser)
	// })
	// }
	// passport.serializeUser(function (user, callback) {
	// callback(null, user.id)
	// })
	// passport.deserializeUser(function (id, callback) {
	// User.findById(id, function (err, user) {
	// callback(err, user)
	// })
	// })
	// })})

You're configuring Express Session twice here!

I think once should be enough

SailCast-podcast/index.js

Lines 45 to 55 in 5ec8758

	app.use(session({
	secret: process.env.SESSION_SECRET || 'ssh it\'s a secret',
	resave: false,
	saveUninitialized: false
	}))
	app.use(session({
	secret: process.env.SESSION_SECRET || 'ssh it\'s a secret',
	resave: false,
	saveUninitialized: false
	}))

env config is 👍

This is cool!

SailCast-podcast/index.js

Line 22 in 5ec8758

const env = require('./config/env')

Cool format for defining your routes

This cool!

SailCast-podcast/config/routes.js

Lines 24 to 31 in 5ec8758

	router.route('/login')
	.get(sessions.new)
	.post(sessions.create)
	router.route('/register')
	.get(registrations.new)
	.post(registrations.create)
	router.route('/logout')
	.get(sessions.delete)