tes3mp/corescripts

The serverside Lua scripts used to implement core functionality in TES3MP.

CoreScripts

These are the scripts used to implement most of the essential server logic in TES3MP, including gameplay adjustments for multiplayer as well as state saving and loading.

• TES3MP version: 0.8.1

corescripts's Issues

Add teleport commands relative to other players

Add teleport commands to teleport the player to another player or vice versa.

This is a very common feature in multiplayer games and it is extremely useful, especially in times of bug hunting.

PS: These commands should be limited to Moderators and Admins.

Don't show admin commands for players

/tp all

I think it would be better than a monkey's work (tp 1, tp 2, tp 3)

Custom script installation

Hi, I'm working on a mod manager for OpenMW called Portmod, and want to include support for installing tes3mp scripts.

At the moment there doesn't seem to be an easy way of including custom scripts without touching the tes3mp installation, which a user program such as Portmod may not have permission to modify, depending on how tes3mp was installed. There is a way of specifying the location of CoreScripts in tes3mp-server.cfg, however making use of that on a system where the original CoreScripts has been installed without user write permissions would require copying or cloning an entirely new CoreScripts directory. This may not be what the user expects and could be confusing, in addition to being a largely unnecessary copy as we only actually need to modify scripts/customScripts.lua.

Would it be possible to support including custom scripts (or more particularly, the customScripts.lua file) in a location specified in tes3mp-server.cfg, or in some fixed directory in ~/.local/share?

tes3mp.SetPos() doesn't work when called from the Lua scripts

I have tried calling tes3mp.SetPos() from the lua scripts without any noticeable effects, there is no debug information in either the openmw or the openmw-mp server console output.

Example of a call:
tes3mp.SetPos(0, 4092, 4092, 1000), should put player pid0 at Z1000 above the spawn point but nothing happens.

tes3mp.GetCell() now returns the wrong cell when on the exterior

tes3mp.GetCell() should return "" when the player is on the exterior, instead it now returns the last interior cell the user visited, since commit TES3MP/TES3MP@7bf08e5

Iterate through players in a way that makes sense

This line, used in so many places, doesn't really work at all:

for i = 0, #Players do

Imagine you have a server that players 0, 1, 2 and 3 have joined. That means #Players is 4 and the loop will go up to 4.

Now imagine players 1 and 2 leave. Suddenly, #Players has a value of 2. That means the loop only goes up to 2, and it's as if player 3 doesn't even exist.

For that reason, something like printing the list of players like this is very wrong:

    for i=0,#Players do
        if i == #Players then
            divider = ""
        else
            divider = "\n"
        end
        if Players[i] ~= nil and Players[i]:IsLoggedIn() then
            list = list .. tostring(Players[i].name)
            list = list .. " (ID: " .. tostring(Players[i].pid)
            list = list .. ", Ping: " .. tostring(tes3mp.GetAvgPing(Players[i].pid)) .. ")"
            list = list .. divider
        end
    end

In the above-mentioned scenario, it will only be able to find player 0.

Here's a screenshot as proof:

http://i.imgur.com/GY7FolQ.png

No function to bring a player from an interior cell to the exterior that is accessible by Lua scripting

Like mentioned in #5

Typo in packetType OnActorDeath event handler

This line of code causes the server to crash

CoreScripts/scripts/eventHandler.lua

Line 1166 in e02ece5

local actors = packetReader.GetActorPacketTables("death").actors

I think it can be fixed this way:

            local actors = packetReader.GetActorPacketTables("ActorDeath").actors

Continuous errors in client log whenever Corprus buff exceeds server limit for attributes

Server crashes when using /kick command

Because of a missing numerical conversion, using the /kick command after commit af0ec05 causes a server crash.