Giter Site home page Giter Site logo

issues's People

Contributors

flashwave avatar o5k avatar zudob avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

issues's Issues

XP in room player listing is wrong

  • Resets to the XP one had at connecting when others enter a room later
  • Users who join midgame do not receive XP but in the room player listing they do

Some UI text gets autoselected during gameplay

Description

UI text gets autoselected during gameplay. This includes:

  • KO list in the upper right corner
  • KO popups during the game that inform you of who you KO'd/who KO'd you
  • Screen that shows who's the winner with their survival time
  • I think I had this issue with pre-game room title text (such as "Quick Play"), but I cannot recall that one too well at the moment.

Reproduction

Unknown. Seems to happen randomly during gameplay.

Expected behavior

Text shouldn't be selected.

Screenshots

image
image

Your setup

Arch Linux 5.5.4-arch1-1 on x86_64 PC, using Firefox 73.0

Secret Grade Detection Bug

Describe the bug/issue

Secret Grade disregards the 20th row, and shouldn't.

Reproducing

Steps to reproduce the behavior:

  1. Build Secret Grade solid to at least S9.
  2. Fail to put the block above the GM hole to actually make GM.
  3. Still succeed to "do the thing"???

Expected behavior

Failure should be returned in this case, and the achievement fails.

Additional context

Request to place in issue-tracker by osk.

targeting attackers

Describe the bug/issue

if you target attackers and your attacker dies, it targets nobody as long as nobody else attacks you

Reproducing

Steps to reproduce the behavior:

  1. target attackers
  2. have someone attack you
  3. they die
  4. attempt to deal damage, as long as nobody else attacks you, the damage goes nowhere

Expected behavior

should find a new target in some arbitrary way

Screenshots

none

Your setup

windows 10
chrome

Additional context

no

Adjustable DAS & ARR (ms)

DAS and ARR 100% adjustable in all ranges.

Like: DAS 0 ~ 333ms (20F) / ARR X ~ 83ms (5F)
Unlike: DAS 17ms (1F)~33ms (2F)~etc.

Targeting options can still be used during 1v1

Description

Targeting options for games with more than 2 players can still be used during 1v1 play. This happens with both bigger lobbies reduced to 2 players through regular play, as well as just 2 player lobbies. Using them will cause the target option switching sound effect to play, while no visual confirmation happens.

Reproduction

  • Start 1v1 match with someone
  • Press one of the targeting keys (1-4)

Expected behavior

Nothing happens upon pressing targeting option keys.

Your setup

Arch Linux 5.5.4-arch1-1 on x86_64 PC, using Firefox 73.0

gravity issue when going above level 115

Describe the bug/issue

gravity alternates between 0 and 20 every other level
116 is 0
117 is 20
118 is 0 etc.

Reproducing

Steps to reproduce the behavior:

  1. go to custom game
  2. set goal as none
  3. play until level 116

Expected behavior

gravity should still be 20

Your setup

windows 10
firefox 73.0

Additional context

not found by me, found by oshisaure while in a call - stats are theirs as well.

Volume settings: Hear damage option

Damage noises are intrusive at high level play with many players involved. Add an option to disable hearing damage (should be on by default), or at least only hear damage sent to you or by you.

Pressing enter doesn't submit password form

Describe the bug/issue

Just a small issue, when setting my email address it asked for my password and pressing enter after typing it in didn't submit, I had to manually click the submit button

Reproducing

Steps to reproduce the behavior:

  1. Go to config
  2. Click on Account
  3. Click save on email (Doesn't need to be changed)
  4. Type a password
  5. Press enter

Expected behavior

I expect this to submit the form

Screenshots

passwordreset

Your setup

  • Fedora 31
  • Chrome 80.0.3987.106 (Official Build) (64-bit)

Achievement system

An achievement system would allow newcomers to work towards goals and have a sense of purpose for starting their grind.

Random lag spikes in multiplayer

In multiplayer seemingly random lag spikes will appear where the game will process no inputs for roughly less than 0.5 seconds. Seems to be particularly notorious in matches with 4+ players. Other players such as Wumbotize have also noticed and complained about this

Quick play lobby is getting stuck

Quick play lobby getting is stuck with message "currently ingame"

osk's prediction:
→ worker dies for Unknown reason (This is bug 1)
→ worker reports a netsplit, server removes all players in the room
→ said players are not removed because unlike disconnects, the entire game object is gone because the worker died
→ the referee never gets to know that the netsplit games have ended (This is bug 2)
→ the referee assumes there is still an ongoing match

Free play while waiting for next game

Is your feature request related to a problem? Please describe.

Lots of players are trash, and die early in big rooms. They need something to do. This is especially good for newer/trasher players who would just leave immediately.

Describe the solution you'd like

Ability to play 40L or Dig.

Describe alternatives you've considered

A few buttons to choose mode while spectating

DAS is not buffered at the start of a game

Holding a movement key during the game start countdown should charge the DAS before the first piece spawns. Currently, the DAS timer kicks in when the game starts instead of it already being ticked off.

Indicator that you're currently being targeted by someone in Multiplayer

In multiplayer matches where there's a sizeable amount of people, you may get a big attack and not be sure from where it came from or not be sure if you can perform a risky strategy to save yourself. An indicator that tells you who is targeting you based on the attack selectors (1, 2, 3, 4) may help make decisions.

Settings don't persist across setups

Switching browsers had me notice all my settings got dropped. These should be carried over to other sessions by storing them on the server. If the reasoning is intentional (for example, due to graphics settings), at the very least pull the last known configuration when starting a new, unknown session.

Word filtering

Is your feature request related to a problem? Please describe.

Some words should be in a public ban list, such as Nigg@ etc.

Describe the solution you'd like

Integrating something like https://pypi.org/project/profanity-filter/ should be simple enough.

Additional context

It should probably be server side since scriptkiddies could find a way to send bad words to the server

Kicks sometimes don't work

Config:
image

Game settings:
image

Repro:

  1. Hold Softdrop key during countdown
  2. When the first piece spawns, it should immediately go to the floor due to our settings.
  3. Without releasing softdrop, attempt to rotate the piece.

No rotation occurs and no rotation sound either. The piece should rotate and floorkick. Works with all pieces apart from O (since it doesn't kick). Tapping movement first and then rotating, still no rotation occurs even though movement does occur.

This has been observed in multiplayer but a bit inconsistently, this repro should work 100% of the time

Some UI text is selectable

Description

You can select some UI texts.

Reproducing

  • Go into quick lobby and select text in the center (either countdown or "quick play, good luck!" text).
  • When the game starts, select the room title.

Expected behavior

Such texts shouldn't be selectable.

Screenshots

image
image

Your setup

Arch Linux 5.5.4-arch1-1 on x86_64 PC, both on Opera 66.0.3515.72 and Firefox 73.0

Additional context

Related to #47

Separate Solo and Multiplayer settings

Separating game parameters for Solo and Multiplayer would be a nice addition. For example, I like to play 40 Line with instant soft drop to try and fix mistakes quickly, but I don't like this in multi where I have to play consistently and tuck pieces precisely. Alternatively, easily switchable presets might be a thing, but sound like more of a hassle to do.

Sound effect spam when coming back to game tab that was inactive

If left for too long and many things happen in the game you left in the inactive tab, the game will play every queued sound effect and visual effect, often causing an incredible earrape.

The only instance where this does not happen is if you come back to the game once the game has been won.

Aggressively zooming in the browser breaks WebGL

Takes some time to repro, but holding down control and spamming mousewheel for a while seems to crash WebGL. Console: WebGL: CONTEXT_LOST_WEBGL: loseContext: context lost. At the very least, suspend the game or display an error if this happens.

Windows 10, Chrome 80

Selectable music for Blitz

It's currently impossible to pick music for Blitz, allow for picking from the soundtrack like 40 Line.

Fin TSD - T piece SRS kick inconsistency

When kicking a Fin TSD, issues can arise and make fins near impossible in multiplayer due to higher gravity.

https://youtu.be/k_mWecOp9bI

As seen in this video, when rotating the piece counter-clockwise (to kick it upwards), it can sometimes automatically drop down to the lower tile without ever being positioned at the upper tile (see 41.000 IGT in the video). This seems to be tied to the gravity, making this kick much harder to do in multiplayer than it should be.

What's expected to happen is something a lot more like this:

https://youtu.be/SOI2xeXsc_k

In PPT, the piece will always kick to the upper tile and the sub-pixel Y value (or gravity timer, depending on the implementation method) will reset, allowing the piece to hover as if it was just dropped into this position.

To mitigate stalling forever, the game employs a check which checks if 15 rotation or movement inputs have been done since the last time the piece reached a new minimum Y tile value. If it exceeds 15, and the piece is currently standing on the ground, it will automatically lock.

Gameplay Presets based on other games

Essentially: a way to have preconfigured sets of Gameplay Settings (DAS, ARR, SDF) that are similar or equal to the other games they're based off.

Can be useful for beginners to use a setting set from a game they come from, and optionally also a "custom" tab for them to modify their settings once they're starting to scale up in speed, for example.
(May also be useful for a "first-run" setup for people that recently registered)

180 Rotations

Jstris speedplayers would like this added, might not be beginner-friendly

Final time is different ingame and in result screen

Description

Final time shown is different from final time shown ingame.

Reproduction

  • Create custom game with "Topping out is OK", with stopwatch shown and with time shown in the end screen
  • Top out

Expected behavior

Time ingame during top out should match time in the result screen.

Screenshots

image
image

Your setup

Arch Linux 5.5.4-arch1-1 on x86_64 PC, using Firefox 73.0

Basic social system

Does not have to be too complex.

  • Friend people to be able to see if they're offline/online/in solo/in multi.
  • Directly message with friends.
  • Friends can be directly invited to a game, which would either create a new room to play in, or if you're already in a room invite them to said room. The invited person would have a non-disruptive but noticeable popup notification in a corner of the screen.
  • Profile pictures
  • Ability to link socials such as Twitter, Discord, YouTube or Twitch (optionally public or private depending on the user's choice) to aid in people connecting and enjoying the game.

KeepassXC tries to autofill non-visible fields

Describe the bug/issue

While in menu, KeepassXC (my password manager) tries to autofill the username, password, password(repeated) and register form and shows an icon even though the fields are not visible. The icons fade away when a game starts.

Reproducing

Steps to reproduce the behavior:

  1. Download and Setup KeepassXC and the Browser extension
  2. Visit the main menu after login

Expected behavior

The Icons are not visible.

Your setup

  • OS and version: Windows 10
  • Browser and version: 80.0.3987.106 with KeepassXC-Browser Version 1.5.4

Screenshots

image
image
image

Additional Infos

I have observed, that the Icons fade away once the game adds the class "ingame" to the body. I manually added the class using chrome's inspector and saw the same behavior (icons fade away).
I found out that the following css triggers the behavior:

.ingame .oob_modal {
    display: none;
}

Suggested Solve

Add display: none to all .oob_modals when they are not visible (so probably to the selector .oob_modal.hidden). Opacity: 0 is not enough for my(and maybe others too) Password Manager to mark it as "not visible"

Offline version (Electron)

An offline executable version in Electron would be another nice addition, for example to play solo modes while offline. It could support some extra features like Discord Rich Presence. Unsure of the demand for this though

DAS optimization techniques not achievable

DAS seems to be entirely cancelled when a second movement key is pressed, which removes the ability to do many DAS optimization techniques.

Easy repro: DAS to right wall, don't release right. Move (tap) one tile left, then release left. The DAS from the still held right input should still be active and start moving based on ARR back to the right side. Currently, no movement happens afterwards and the piece is left 1 tile away from the wall, even though the movement key is still being held.

For other examples which aren't doable in tetr.io, see this Hard Drop Wiki page on DAS optimization

0G isn't really 0G

As mentioned during discussion:

[19:17] osk: ye, 0g makes it default to something and idk what
[19:17] osk: 0.15
[19:17] osk: because idk i was lazy and made it a very simple check, so 0 becomes 0.15
[19:18] osk: either use 0.0001 or -1

I'd consider this a bug for following reasons:

  • 0G is faster than some values higher than it, such as 0.0001
  • Intuitively 0G should mean no gravity in first place
  • There is a different default value for custom games already filled in (0.02).

ARR 0

Jstris speedplayers would like this added, might not be beginner-friendly

Blitz: Time countdown display jitters

Due to the fluctuating width of the milliseconds value, the timer's minute:second display visually jitters left-to-right. Much more noticeable on 144Hz than on 60Hz, but still definitely visible. Timer should stay aligned at all times.

Windows 10, Firefox 72

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.