tetujin/aware-client-ios

http://awareframework.com

aware-client-ios's Issues

Confusing failure message when wifi_only=True or charging_only=True and manual upload

When wifi_only=True or charging_only=True, if you do a manual upload and those conditions are not met, you get a generic failure message, instead of something saying which condition is not true. This was very confusing, and together with the next issue I am about to submit resulted in a lot of debugging.

I'd suggest either "manual upload" does not follow those conditions, or if the conditions are not met then have a special error message. (Or else, the generic message could have "or upload conditions not met" to at least point out there could be other problems.

Thanks,

• Richard

Building Instructions

I tried building the app but I cannot find any app specific build instruction and Makefile only has documentation related instructions. I tried normal pod install and building in XCode but seems like the default build steps are not working as expected. So far:

1. File ViewController.m has the wrong path in build phases (it tries looking in aware-client-ios/ViewController.m while it should be looking at aware-client-ios/AWARE/ViewController.m)
2. Fixing first problem by manually editing build phases, it tries to proceed to link phase but it fails with: ld: warning: directory not found for option '-L/Users/badiea1/aware-client-ios/build/Debug-iphoneos' (I was building for simulator so it should have been looking for Debug-iphonesimulator i guess)
3. Solving that one (by removing directory from library search path) will make it fail with duplicate symbol _notificationCallback in MDBluetoothManager.o and BluetoothScanner.o.

So either I'm doing something completely wrong or the correct way to build is not just installing cocoapods and building in XCode.

aware_debug sometimes makes invalid JSON

Hi,

I have been working to debug a server error and it seems that sometimes the aware_debug table produces invalid JSON. This has been happening for weeks now, so it is something persistent (something in the DB or code, not a one-time thing that happens on upload). The location of the first error (location in uploaded data) is at the same byte offset in the uploaded data, too, also implying it is persistent. The python error message is:

JSONDecodeError at /index.php/aware/v1/.../aware_debug/insert
Expecting ',' delimiter: line 1 column 2193 (char 2192)

Here is an example of where the error occurs:

"battery":86},141567798,"network":"wifi","

When looking at the data and replacing all the valid JSON objects, the first error is this, which exists where an object should otherwise be within the list of rows being uploaded:

141567798,"network":"wifi","battery":86}

Looking in more detail, it seems like the first part of the text of the JSON objects is missing and we consistently have the trailing end of the JSON data. The excerpt above is unique, most of the fragments look like this (this beginning and end text is usually the same, the underscores are a lot of apparently valid JSON with the keys type and timestamp)

","battery_state":1,"label":______________"network":"wifi","battery":81}

This only seems to happen in the aware_debug table, and it appears busty (many rows are fine, then most rows are not fine, etc). Some aware_debug rows were successfully uploaded a long time ago but once this starts, no more succeed (since the server isn't accepting uploads anymore). I have never seen a similar error with another table's upload.

Do you have any thoughts?

Thanks,

• Richard

QRCode Button

When running the app on the simulator (iPhone 6s) and pressing QRCode the app crashes.

This is the output:
2016-02-15 16:54:02.102 AWARE[985:434127] Hello ESM view ! 2016-02-15 16:54:02.119 AWARE[985:434127] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** Can't add a nil AVCaptureInput' *** First throw call stack: ( 0 CoreFoundation 0x0000000105c51e65 __exceptionPreprocess + 165 1 libobjc.A.dylib 0x00000001095b9deb objc_exception_throw + 48 2 AVFoundation 0x00000001092e37fa -[AVCaptureSession _addInputWithNoConnections:] + 794 3 AVFoundation 0x00000001092e31a9 -[AVCaptureSession addInput:] + 96 4 AWARE 0x0000000104be4310 -[QRCodeViewController viewDidLoad] + 992 5 UIKit 0x0000000106faff98 -[UIViewController loadViewIfRequired] + 1198 6 UIKit 0x0000000106fb5f4f -[UIViewController __viewWillAppear:] + 120 7 UIKit 0x0000000106fe5e44 -[UINavigationController _startCustomTransition:] + 1203 8 UIKit 0x0000000106ff623f -[UINavigationController _startDeferredTransitionIfNeeded:] + 712 9 UIKit 0x0000000106ff73af -[UINavigationController __viewWillLayoutSubviews] + 57 10 UIKit 0x000000010719dff7 -[UILayoutContainerView layoutSubviews] + 248 11 UIKit 0x0000000106ed04a3 -[UIView(CALayerDelegate) layoutSublayersOfLayer:] + 703 12 QuartzCore 0x000000010cf0959a -[CALayer layoutSublayers] + 146 13 QuartzCore 0x000000010cefde70 _ZN2CA5Layer16layout_if_neededEPNS_11TransactionE + 366 14 QuartzCore 0x000000010cefdcee _ZN2CA5Layer28layout_and_display_if_neededEPNS_11TransactionE + 24 15 QuartzCore 0x000000010cef2475 _ZN2CA7Context18commit_transactionEPNS_11TransactionE + 277 16 QuartzCore 0x000000010cf1fc0a _ZN2CA11Transaction6commitEv + 486 17 QuartzCore 0x000000010cf2037c _ZN2CA11Transaction17observer_callbackEP19__CFRunLoopObservermPv + 92 18 CoreFoundation 0x0000000105b7d367 __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ + 23 19 CoreFoundation 0x0000000105b7d2d7 __CFRunLoopDoObservers + 391 20 CoreFoundation 0x0000000105b72f2b __CFRunLoopRun + 1147 21 CoreFoundation 0x0000000105b72828 CFRunLoopRunSpecific + 488 22 GraphicsServices 0x000000010a97bad2 GSEventRunModal + 161 23 UIKit 0x0000000106e19610 UIApplicationMain + 171 24 AWARE 0x0000000104c231af main + 111 25 libdyld.dylib 0x0000000109b5592d start + 1 26 ??? 0x0000000000000001 0x0 + 1 ) libc++abi.dylib: terminating with uncaught exception of type NSException

Full app restart required in order for wifi_only and charging_only to be changed

Hi,

I found that if I change the wifi_only and changing_only options in the Advanced Settings UI within the app, the changes do not come into effect until the app has a full restart (as in remove from background apps and restart). This resulted in quite a bit of random testing to find!

At least "requires full restart" could be added to these setting descriptions to save someone else some debugging time...

Thanks,

• Richard

Best practice to use client with updated framework

I’m attempting to build a version of your AWARE application from this repo with the files in your AWAREFramework-iOS framework. I noticed that although the same folders exist in both (ie core, ESM), the files in your AWAREFramework-iOS framework seem to be more recent. Do you have any advice on do this? Thank you for your work on these projects.