textkernel/tx-dotnet

The official C# SDK for the Textkernel Tx v10 API. Includes a resume parser (CV parser), job parser, resume search engine, and resume matching engine.

tx-dotnet's Issues

easyAccess?.GetPhoneNumbers() - System.ArgumentNullException: 'Value cannot be null. (Parameter 'source')'

Hello,

_profile.PhoneNumber = easyAccess?.GetPhoneNumbers()?.FirstOrDefault()
Is throwing an error of type Value cannot be null. (Parameter 'source')

Unable to filter on lat/long

FilterCriteria.LocationCriteria.Locations[0].GeoCoordinates is a class of the wrong type. It should be a GeoPoint. This causes it not to be respected when it's serialized and sent to the API.

Error deserializing data that was serialized prior to v1.7.0

ParsedResume and ParsedJob objects serialized with versions prior to v1.7.0 (#48) cannot be deserialized with later versions because of this change

Creating a DataCenter for self-hosted (on-prem) causes a '//' in the URL

The Version property is left null when the constructor is used on the DataCenter class, and then used later in the ApiEndpoints class without a null check.

'Configuration' object not in request for Job Parsing

https://sovren.com/technical-specs/latest/rest-api/job-order-parser/api/?h=Configuration

This object and child parameters are missing from the request object for job parsing.

SovrenClient.DeleteMultipleDocuments throws System.NotSupportedException: 'DELETE cannot have a body'

Using Sovren.SDK v1.5.1 and .NET 5.0 and getting this exception:

{
	"ClassName": "System.NotSupportedException",
	"Message": "DELETE cannot have a body",
	"Data": {},
	"InnerException": null,
	"HelpURL": null,
	"StackTraceString": "   at Sovren.Rest.RestRequest.AddJsonBody(String json, Encoding encoding)",
	"RemoteStackTraceString": null,
	"RemoteStackIndex": 0,
	"ExceptionMethod": null,
	"HResult": -2146233067,
	"Source": "Sovren.SDK",
	"WatsonBuckets": null
}

Run unit tests in GH actions when a PR is created

• Also require the action to be successful for the PR to be completed
• Add a badge with the unit tests status to the readme

Capturing raw JSON output

I am attempting to store the raw JSON response from a resume parsing using the SDK. I am using the basic example of:

ParseRequest request = new ParseRequest(doc, new ParseOptions());

When examining the SkillsData output in response.Value.ResumeData I am not seeing the values for ID, Name, or PercentOfOverall. The same is happening when looking at the SubTaxonomies. This data is all present when looking at the SkillsData = List<Sovren.Models.Resume.Skills.ResumeTaxonomyRoot> in the response. Is this by design? The information is also displayed when using the demo parser on the Sovren website.

Thank you.

SovrenClient and dependency injection/unit testing

From a customer request:

We have been using the Sovren V10 SDK in a couple of our microservices and for the most part its working great, however there is one issue we’ve had. Since the SovrenClient class is marked as sealed, it has been difficult to mock in tests and register in dependency injection. We have created an adapter class around SovrenClient for the time being as a workaround, but we were curious if there was a reason for this class to be sealed or if some changes could be made to better support dependency injection/unit testing. Our ideal scenario would be to have SovrenClient inherit from an ISovrenClient interface with an extension method provided by the SDK to add ISovrenClient to the DI service registrations (e.g. “services.AddSovrenClient()”).

Better error messages for 400-level or 500-level errors

Improve the error messages when the response body does not contain an Info/Value object as expected.