tf2stadium/helen

Chief backend API server for TF2Stadium

helen's Issues

Sending lobbyJoin while being in another lobby.

Right now, when you're in a lobby spot and you try to join a spot in a different lobby, you'll get an error saying "Player is already in a lobby". I suggest that Helen removes the player from his original spot and lets him join the new lobby.

Being able to join multiple lobbies as player in the same time

See Title, switching slot works proper (Get removed from old, get placed in old), however, the lobby does not remove me from other lobbies.

Client timeout

Users need to be timed out and removed from lobby slots if they have no active websocket connections for some period of time (2 minutes-ish?)

Sending too many lobbyData messages

When clients send lobbyJoin, they tend to receive multiple redundant messages (described below) (all before the lobbyJoin response).

This includes (sometimes duplicated) copies of the lobbyData with them not in their old slot, and then (again, sometimes duplicated 2+ times) copies of the lobbyData with them in their new slot.

Interspersed are also multiple lobbyListData messages.

Send league on `lobbyData`

If possible, make it either:

• Have two fields: name (e.g. AsiaFortress) and value (asiafortress).
• Only send the name, since it's what will be displayed on the page. However, this might change in the future, so the first option would be wiser.

Add support for lobby creation settings list.

At the moment, the Frontend is managing the entire list of options to create a lobby (formats, maps, leagues...). Ideally, Helen should provide it instead. The exact structure of the returned JSON may vary, but check the current code we use for it:

https://github.com/TF2Stadium/Frontend/blob/master/src/app/pages/lobby/create/lobby-create.provider.js#L52

Server model

Have a server model that would use the Rcon wrapper and have functions like verify and setup. Find a place to store configs, read them and execute them during setup. (the wrapper has a method ExecConfig(config string))

Spectators don't get removed from the spectator list if the lobby is closed

Player can ban himself from his own lobby

Sending lobbyKick with ban=true should return an error if the steamid is empty or equal to the sender. In other cases, a new leader should be assigned (I suggest that if a user with role admin or moderator bans the lobby leader, he gets assigned as the new leader).

Send `chatReceive` history through the Public Rooms

Right now, you only get the chat history of a lobby when you join a slot in it. What should happen is that you receive it when you join the Public Room.

Data Race during DB Migration

Build Helen with go build -race, execute the generated binary.

Complete data race info from the Go data race tool:

WARNING: DATA RACE
Read by goroutine 9:
runtime.mapaccess2()
/build/go/src/go-1.5.1/src/runtime/hashmap.go:320 +0x0
github.com/jinzhu/gorm.(_Scope).GetModelStruct()
/home/vibhavp/go/src/github.com/jinzhu/gorm/model_struct.go:94 +0x2f5
github.com/jinzhu/gorm.(_Scope).GetStructFields()
/home/vibhavp/go/src/github.com/jinzhu/gorm/model_struct.go:380 +0x41
github.com/jinzhu/gorm.(*Scope).GetModelStruct.func1()
/home/vibhavp/go/src/github.com/jinzhu/gorm/model_struct.go:291 +0x656c

Previous write by main goroutine:
runtime.mapassign1()
/build/go/src/go-1.5.1/src/runtime/hashmap.go:411 +0x0
github.com/jinzhu/gorm.(_Scope).GetModelStruct()
/home/vibhavp/go/src/github.com/jinzhu/gorm/model_struct.go:372 +0x1037
github.com/jinzhu/gorm.(_Scope).TableName()
/home/vibhavp/go/src/github.com/jinzhu/gorm/scope.go:282 +0x2f6
github.com/jinzhu/gorm.(_Scope).autoMigrate()
/home/vibhavp/go/src/github.com/jinzhu/gorm/scope_private.go:586 +0x52
github.com/jinzhu/gorm.(_DB).AutoMigrate()
/home/vibhavp/go/src/github.com/jinzhu/gorm/main.go:411 +0xf5
github.com/TF2Stadium/Helen/database/migrations.Do()
/home/vibhavp/go/src/github.com/TF2Stadium/Helen/database/migrations/migrations.go:13 +0x13f
main.main()
/home/vibhavp/go/src/github.com/TF2Stadium/Helen/main.go:33 +0x62

Goroutine 9 (running) created at:
github.com/jinzhu/gorm.(_Scope).GetModelStruct()
/home/vibhavp/go/src/github.com/jinzhu/gorm/model_struct.go:370 +0xfc1
github.com/jinzhu/gorm.(_Scope).TableName()
/home/vibhavp/go/src/github.com/jinzhu/gorm/scope.go:282 +0x2f6
github.com/jinzhu/gorm.(_Scope).autoMigrate()
/home/vibhavp/go/src/github.com/jinzhu/gorm/scope_private.go:586 +0x52
github.com/jinzhu/gorm.(_DB).AutoMigrate()
/home/vibhavp/go/src/github.com/jinzhu/gorm/main.go:411 +0xf5
github.com/TF2Stadium/Helen/database/migrations.Do()
/home/vibhavp/go/src/github.com/TF2Stadium/Helen/database/migrations/migrations.go:13 +0x13f
main.main()
/home/vibhavp/go/src/github.com/TF2Stadium/Helen/main.go:33 +0x62

Send lobbyStart/lobbyReadyUp upon connection.

If the player connection to the backend drops for any reason and the lobby is in the ready-up state or has already started, the Frontend will never receive those requests and it'll be impossible to retrieve the information.

Alternatively, and I think this is a better solution, send the lobby connection information in lobbyData, but only to the players, and only if the lobby has already started. That way we can avoid non-players getting the info to attack the lobby.

Lobby info announcements in chat don't use name alias

Set up the asset pipeline

RoR description: "The asset pipeline provides a framework to concatenate and minify or compress JavaScript and CSS assets. It also adds the ability to write these assets in other languages and pre-processors such as CoffeeScript, Sass and ERB."

As for golang, https://github.com/shaoshing/train looks like an all-around good system for that so I think integrating it would be a good choice. If that doesn't work, SASS compilation (and probably fingerprinting) would need to be added manually.

The current idea is to use gulp for that.

User doesn't get lobbyClosed/lobbyLeft if lobby ends correctly

Spectators get duplicated.

Request lobbyKick returns 'Not authorized to remove players'

Both for the lobby leader and for a user with the administrator role, but it works on the player itself.

Message responses are quoted too much

For example (with the wsevent wrapping):

Send: {"id":"1","data":{"id":6,"team":"blu","class":"scout","request":"lobbyJoin"}}
Receive: {id":"1","data":""{\"data\":{},\"success\":true}""}

Where as the following would be expected:

Send: {"id":"1","data":{"id":6,"team":"blu","class":"scout","request":"lobbyJoin"}}
Receive: {id":"1","data":"{"data":{},"success":true}"}

(and really, the fact that data is an object client->server but a string server->client is quite inconsistent)

Wrong behaviour on lobbyClose/lobbySpectatorLeave.

If a user is spectating a lobby and is a player at the same time, the lobby gets closed and he leaves the lobby via lobbySpectatorLeave, Helen will answer with "Player not spectating".

Player does not receive chatReceive via private rooms.

This creates an issue in which the lobby chat will not update if the user is in another page.

Some combination of cfgs/plugin/servers doesn't get executed properly

UGC + gcommer's server didn't work.

lobbyData not sent if client spectates already joined lobby

A client that sends lobbyJoin and then lobbySpectatorJoin (for the same lobby id) will receive a single lobbyData message, but then no more. This behavior can be demonstrated on the current frontend by clicking to join a lobby slot directly from the lobby list.

Websocket is still receiving lobbyData from different lobbies.

Possibly due to #108.

Handle errors while configuring servers

While setting up a server, we can encounter the follow errors:

passErr := s.Rcon.ChangeServerPassword(s.LobbyPassword)
kickErr := s.KickAll()
cfg, cfgErr := config.Get()
configErr := s.ExecConfig(config)
mapErr := s.Rcon.ChangeMap(s.Map)

These errors need to appropriately converted to TPError type and sent to the user. In case of errors like mapErr, a correct map needs to be taken by the user, and then changed.

Create new request `chatHistoryReceive`

Currently, chat history is sent via several chatReceive on connection. I suggest creating a new request for this case that holds all those messages.

Wrong lobbyJoin behaviour in restricted lobbies.

Currently, when a lobby has both a player whitelist and a password, you need to be in the whitelist and enter the correct password. It needs to be whitelist OR password.

User lobby count doesn't get updated.

Lobby doesn't get closed when the match ends

Sender does not receive chatReceive Event

In order to receive the role of the sender it would be useful that also the sender of the chatSend event receives the chatRecevie event. Alternative would be to send the data in the callback?

Shorten the time it takes for the site whitelist to update.

It's now at 5 mins, it could be lowered to 2-3 mins.

Add socket to rooms when reconnecting

Currently sockets are only added to rooms after lobbyJoin messages. This is bad if the server or a client temporarily loses connection and reconnects - we should add new sockets to rooms they should belong to on connection

Steam OpenID login integration

We need to support logging in through steam. For now, this task includes successfully logging in and retrieving the authentication token; integration with the rest of the system will come later

This might help: https://github.com/yohcop/openid-go

Region lobbyListData has wrong name field

Both fields of region (code and name) are the same.

Send last n chat messages on connection.

The client should receive every message from a lobby/general chat up until a certain number on connection. That way we can show the chat history.

Allow spectating lobbies without logging in.

Multiple bugs

• When someone reconnect, make them join the public AND private rooms of the lobby they're PLAYING.
• On lobbyJoin, make them join the PRIVATE ROOM, on lobbySpectatorJoin, make them join the PUBLIC ROOM
• When someone disconnects, we get the Steam ID from their socket ID, then check if there are multiple connected sockets for that SteamID. If there no more sockets left (no tabs): We remove them from the spectator of the lobby they were spectating. If there are sockets left*, we check if these sockets are spectating the same lobbies the previous socket was. If no, the player is removed the from the spectator slot of these lobbies.

Users can leave lobbies after they start.

Users can join lobbies after they are closed.

Also, you don't get removed from the spots you're already in, which means you can open a lobby, close it, then fill every single slot by yourself, receive lobbyReadyUp and start the lobby with one player.

Use TF2 whitelist strings instead of integer/IDs

TF2Stadium/QA#3

Handle Slot Change in lobby.go

We still have to implement a way that a player can change his slot in a lobby he already joined.

Broadcast lobbyJoin/lobbyKick messages as events to everyone

Currently those messages are sent strictly to the related parties (and sometimes not even then: eg if a player gets kicked by lobby leader, the kicked player doesn't get a lobbyKick message, he just gets new lobbyData without him in his slot).

It would be both more efficient to only send the changed data, and makes things significantly easier for the frontend.

Add fallback for servers which have disabled log redirection

Today's many bugs

• The server crashes when someone connects with a token which is not in the DB
• PlayerStatsScraper response parsing issues
• RconWrapper GetPlayers crashes at line 63

User doesn't get lobbyJoined when joining a different slot on the same lobby he is at the moment.

Deployment

Work on setting up some kind of deployment pipeline. A CI system would be ideal, but a nice build and run script would be enough for now.

Too much information in lobbyListData

http://pastebin.com/UNhUKgXG

The slots aren't supposed to contain player information (only filled).

Set up mongodb integration

We'll use mongodb for persistent storage. You need to integrate http://labix.org/mgo with the project and write a few examples (like saving and loading player models from the database) (the player model is definitely not yet finalized so don't spend a lot of time on that - just make sure it works)

Lobby spectators list doesn't use site aliases

lobbyData does not contain envelop

When being a player in a lobby and receiving its updates, the message sent by the server does not contain a envelop/event name?

WebSocket extract:

42["lobbyListData","{\"lobbies\":[{\"classes\":{\"demoman\":{\"blu\"[...]

LobbyData:

42["{\"classes\":{\"demoman\":{\"blu\":{\"name\":\[...]

If serveme.tf reservation ends, lobby isn't closed