thatrevguy/windows_firewall

windows_firewall's Issues

Issue applying a windows_firewall rule when a local_port or remote_port is defined with "IPHTTPS".

JSON rules:

    "Core Networking - IPHTTPS (TCP-In)": {
      "description": "Inbound TCP rule to allow IPHTTPS tunneling technology to provide connectivity across HTTP proxies and firewalls.",
      "application_name": "System",
      "protocol": 6,
      "local_ports": "IPHTTPS",
      "remote_ports": "*",
      "local_addresses": "*",
      "remote_addresses": "*",
      "direction": 1,
      "interface_types": "All",
      "enabled": true,
      "grouping": "@FirewallAPI.dll,-25000",
      "profiles": 2147483647,
      "action": 1
    },
    "Core Networking - IPHTTPS (TCP-Out)": {
      "description": "Outbound TCP rule to allow IPHTTPS tunneling technology to provide connectivity across HTTP proxies and firewalls.",
      "application_name": "C:\\Windows\\system32\\svchost.exe",
      "service_name": "iphlpsvc",
      "protocol": 6,
      "local_ports": "*",
      "remote_ports": "IPHTTPS",
      "local_addresses": "*",
      "remote_addresses": "*",
      "direction": 2,
      "interface_types": "All",
      "enabled": true,
      "grouping": "@FirewallAPI.dll,-25000",
      "profiles": 2147483647,
      "action": 1
    },

Error output by Puppet:

Error: /Stage[main]/Windows_firewall/Windows_firewall[windows_firewall]/Firewall_rule[Core Networking - IPHTTPS (TCP-In)]: Could not evaluate: (in OLE method `localports': )
    OLE error code:8007000D in <Unknown>
      <No Description>
    HRESULT error code:0x80020009
      Exception occurred.
Error: /Stage[main]/Windows_firewall/Windows_firewall[windows_firewall]/Firewall_rule[Core Networking - IPHTTPS (TCP-Out)]: Could not evaluate: (in OLE method `remoteports': )
    OLE error code:8007000D in <Unknown>
      <No Description>
    HRESULT error code:0x80020009
      Exception occurred.

Compatibility Windows server 2016

Dear developer,

I want to use your forge module, since it's able to purge unmanaged firewall rules and thus is able to maintain a kind of 'desired state configuration'.

Unfortunately, it's incompatible with Windows Servers 2016.

Can this be added?

Thanks in advance.

with kind regards,
Tom

Disable Firewall Profiles

I just would like to use the module to Disable the Firewall Profiles, but I´m not being able to do it, sicne it keep complainign that "windows_networks" information was not found.

How can I use this module for just disable the Firewall Profiles?

Regards,

Josef Prado

facter/firewall_policy.rb breaks linux nodes

Hi,

I really like this module for windows firewall configuration, but today i tried to add a linux node to my puppet master, and had problems running puppet.

I've traced it back to the facter scripts of windows_firewall.

Error: Could not retrieve local facts: private method chomp' called for nil:NilClass Error: Failed to apply catalog: Could not retrieve local facts: private methodchomp' called for nil:NilClass

It seems the following line gives the problem:
state = Facter::Util::Resolution.exec(cmd).chomp
https://github.com/hathoward/windows_firewall/blob/master/lib/facter/firewall_policy.rb#L2

This is being executed before the confine is defined, so it is also executed on Linux.
Moving it after the confine (twice) fixes it.
I'll check if i can do a pull request tonight.

Pieter

OS recognition broken?

Trying to run this on a Server 2012 R2 system and getting the following in the event log:

Could not retrieve catalog from remote server: Error 400 on SERVER: firewall: Kernel 'windows' is not currently supported at firewall/manifests/init.pp