thebusybiscuit/hotbarpets

This is the Source Code of my Slimefun Addon "HotbarPets". Inspired by the famous mod "InventoryPets"

Hello 👋, I'm TheBusyBiscuit!

🍪 About me

Student at University, coffee enthusiast and Open-Source software developer.
I am currently maintaining @Slimefun and @MockBukkit.

---

🏆 Meaningless but shiny

---

📚 Tools and languages

               

               

               

---

🎨 Image credit

Profile picture, Slimefun logo and dough logo drawn by @IAmSorry_Art <3.

hotbarpets's Issues

Dragon pet bypasses some protection plugins

Description (Required)

The dragon pet's damage seems to be bypassing Towny protections.
It also damages the owner of the pet in world guard, it does not damage other players.

Steps to reproduce the Issue (Required)

Using the dragon pet, pew pew people.

Expected behavior (Required)

Should have done nothing while in protected land. Towny can add more potion effects to disable while in protections, I just couldn't figure out if this falls under a potion effect or not.

Server Log / Error Report

No errors found.

Environment (Required)

Paper git-Paper-629 (MC: 1.16.5)
Slimefun DEV - 916 (git e4225d7a)
Metrics-Module #22
Java 11

Installed Addons: (19)
DyedBackpacks vDEV - 15 (git 5f5e8b9e)
ExtraTools vDEV - 28 (git 58488a2e)
EcoPower vDEV - 4 (git 2a08d31d)
DynaTech vDEV - 112 (git d3b25f13)
HotbarPets vDEV - 37 (git 63b1553)
SlimefunLuckyBlocks vDEV - 35 (git 3b6586d6)
ExoticGarden vDEV - 76 (git d148a362)
HeadLimiter v9
Liquid vDEV - 11 (git bea52454)
InfinityExpansion vDEV - 111 (git 461a3fd6)
SFCalc vDEV - 23 (git 3c34990c)
IllegalStack v2.2.2a
SlimyTreeTaps vDEV - 19 (git 69930ef7)
PrivateStorage vDEV - 17 (git 43d35d74)
ColoredEnderChests vDEV - 22 (git 7c92625c)
GeneticChickengineering v1.2.0
FluffyMachines vDEV - 81 (git 67fa6406)
CMI v8.8.3.9
ChestTerminal vDEV - 43 (git 3096bab5)

Ghast and Dragon pet bypass PvP

Description

Ghast pet and Dragon pet bypass PvP
Even when a person has PvP off , the ghast pet and dragon pet are able to kill that person

Steps to reproduce the Issue

My pc is bad so could not record but hope you can see that the dragon fireball is able to damage and kill the another player even though PvP is off

Expected behavior

No damage done to the player because PvP is off

Server Log / Error Report

N/A

Environment

[Mon 07:48:16 INFO ] This Server uses the following setup of Slimefun:
Paper git-Paper-216 (MC: 1.18.1)
Slimefun DEV - 1006 (git 114de629)
Metrics-Module #28
Java 17
Installed Addons: (34)
GlobalWarming vDEV - 11 (git 73ff77d4)
SlimeBot v1.1.0
Networks vDEV - 32 (git aaff3aac)
CrystamaeHistoria vDEV - 59 (git d9361aae)
ExtraTools vDEV - 33 (git 46d26e49)
AureliumSkills vBeta 1.2.10
FoxyMachines vDEV - 55 (git c1b69ec7)
FNAmplifications vDEV - 54 (git b26bd8f8)
SimpleMaterialGenerators vDEV - 4 (git 5543cc8f)
DynaTech vDEV - 160 (git e1075a1c)
ExtraGear vDEV - 13 (git c62047e2)
SFAdvancements vDEV - 9 (git e90d0f72)
CMILib v1.1.2.3
InfinityExpansion vDEV - 137 (git 4b326e08)
SFCalc vDEV - 37 (git dfc0fc41)
ElectricSpawners vDEV - 23 (git 6ec96773)
MobCapturer vDEV - 17 (git c21b00a5)
SlimyTreeTaps vDEV - 20 (git 963f0383)
FlowerPower vDEV - 13 (git 06ad45dc)
SlimeTinker vDEV - 71 (git a226bf46)
TranscEndence vDEV - 40 (git cfc98363)
FluffyMachines vDEV - 106 (git 38aa2740)
DyedBackpacks vDEV - 17 (git 8b329e96)
HotbarPets vDEV - 38 (git fa6c871)
SlimefunLuckyBlocks vDEV - 36 (git 60f0c8dc)
ExoticGarden vDEV - 78 (git 7f9a5f63)
DankTech2 vDEV - 4 (git 803760fb)
Liquid vDEV - 14 (git 0f5346bf)
SlimeCustomizer vDEV - 24 (git f6aa53e9)
LiteXpansion vDEV - 174 (git e36d509d)
ElementManipulation vDEV - 9 (git 4d3ceae6)
SoulJars vDEV - 23 (git b8358a1f)
EquivalencyTech v${project.version}
PotionExpansion vDEV - 5 (git e2cfcd8a)

• Minecraft Version: Paper git-Paper-216 (MC: 1.18.1)
• CS-CoreLib Version: N/A
• Slimefun Version: Slimefun DEV - 1006 (git 114de629)
• HotbarPets Version: HotbarPets vDEV - 38 (git fa6c871)

1.15 reflection warning

I'm running the plugin on Paper 1.15.

[14:53:24 WARN]: java.lang.NoSuchMethodException: net.minecraft.server.v1_15_R1.TileEntitySkull.getGameProfile()
[14:53:24 WARN]:        at java.lang.Class.getMethod(Class.java:1786)
[14:53:24 WARN]:        at me.mrCookieSlime.CSCoreLibPlugin.general.World.CustomSkull.<clinit>(CustomSkull.java:42)
[14:53:24 WARN]:        at io.github.thebusybiscuit.hotbarpets.groups.FarmAnimals.load(FarmAnimals.java:27)
[14:53:24 WARN]:        at io.github.thebusybiscuit.hotbarpets.groups.FarmAnimals.<init>(FarmAnimals.java:17)
[14:53:24 WARN]:        at io.github.thebusybiscuit.hotbarpets.HotbarPets.onEnable(HotbarPets.java:48)
[14:53:24 WARN]:        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:263)
[14:53:24 WARN]:        at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:338)
[14:53:24 WARN]:        at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:420)
[14:53:24 WARN]:        at org.bukkit.craftbukkit.v1_15_R1.CraftServer.enablePlugin(CraftServer.java:468)
[14:53:24 WARN]:        at org.bukkit.craftbukkit.v1_15_R1.CraftServer.enablePlugins(CraftServer.java:382)
[14:53:24 WARN]:        at net.minecraft.server.v1_15_R1.MinecraftServer.a(MinecraftServer.java:481)
[14:53:24 WARN]:        at net.minecraft.server.v1_15_R1.DedicatedServer.init(DedicatedServer.java:290)
[14:53:24 WARN]:        at net.minecraft.server.v1_15_R1.MinecraftServer.run(MinecraftServer.java:884)
[14:53:24 WARN]:        at java.lang.Thread.run(Thread.java:748)

Plugin is enabled, though.

Bed pet resets world time

Using bed pet ignores vanilla stipulations for beds (all players on server must be either AFK or sleeping to initiate change to night/day)... and will change the current time of the server to night even if beds are disabled on the server. (Annoying as this puts the moons of my worlds out of synch which we'd like to remain constant for our werewolves)
Can this be altered to only affect ptime of the player using it to avoid this problem?

[12:41:42 INFO]: Paper v1_14_R1
[12:41:42 INFO]:
[12:41:42 INFO]: CS-CoreLib vDEV - 77 (git 6e171836)
[12:41:42 INFO]: Slimefun vDEV - 278 (git f818668b)
[12:41:42 INFO]:
[12:41:42 INFO]: Installed Addons (12)
[12:41:42 INFO]: Barrels vDEV - 7 (git 0d14dd9f)
[12:41:42 INFO]: SlimeXpansion vDEV - 4 (git 5bf10c29)
[12:41:42 INFO]: ExtraGear vDEV - 3 (git de222ab7)
[12:41:42 INFO]: ChestTerminal vDEV - 17 (git 933a7d36)
[12:41:42 INFO]: EmeraldEnchants vDEV - 5 (git 6adbbb87)
[12:41:42 INFO]: HotbarPets vDEV - 20 (git cd87bc6)
[12:41:42 INFO]: ExoticGarden vDEV - 22 (git a855f5b7)
[12:41:42 INFO]: SoulJars vDEV - 4 (git 4a600aa2)
[12:41:42 INFO]: SlimefunOreChunks vDEV - 2 (git 24d90a3e)
[12:41:42 INFO]: ElectricSpawners vDEV - 5 (git c3f8cc9d)
[12:41:42 INFO]: ExtraHeads v1.1
[12:41:42 INFO]: ColoredEnderChests vDEV - 7 (git 6885cb88)

Console Spam?

.... [15:24:05 ERROR]: Could not pass event EntityDamageByEntityEvent to HotbarPets vDEV - 23 (git 37b5010)
java.lang.ClassCastException: org.bukkit.metadata.FixedMetadataValue cannot be cast to org.bukkit.entity.Player
at io.github.thebusybiscuit.hotbarpets.HotbarPetsListener.onTNT(HotbarPetsListener.java:140) ~[?:?]
at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor619.execute(Unknown Source) ~[?:?]
at org.bukkit.plugin.EventExecutor.lambda$create$1(EventExecutor.java:69) ~[patched_1.15.2.jar:git-Paper-77]
at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80) ~[patched_1.15.2.jar:git-Paper-77]
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[patched_1.15.2.jar:git-Paper-77]
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:545) ~[patched_1.15.2.jar:git-Paper-77]
at org.bukkit.craftbukkit.v1_15_R1.event.CraftEventFactory.callEvent(CraftEventFactory.java:232) ~[patched_1.15.2.jar:git-Paper-77]
at org.bukkit.craftbukkit.v1_15_R1.event.CraftEventFactory.handleEntityDamageEvent(CraftEventFactory.java:860) ~[patched_1.15.2.jar:git-Paper-77]
at org.bukkit.craftbukkit.v1_15_R1.event.CraftEventFactory.handleEntityDamageEvent(CraftEventFactory.java:837) ~[patched_1.15.2.jar:git-Paper-77]
at org.bukkit.craftbukkit.v1_15_R1.event.CraftEventFactory.handleLivingEntityDamageEvent(CraftEventFactory.java:1026) ~[patched_1.15.2.jar:git-Paper-77]
at net.minecraft.server.v1_15_R1.EntityLiving.damageEntity0(EntityLiving.java:1691) ~[patched_1.15.2.jar:git-Paper-77]
at net.minecraft.server.v1_15_R1.EntityHuman.damageEntity0(EntityHuman.java:878) ~[patched_1.15.2.jar:git-Paper-77]
at net.minecraft.server.v1_15_R1.EntityLiving.damageEntity(EntityLiving.java:1049) ~[patched_1.15.2.jar:git-Paper-77]
at net.minecraft.server.v1_15_R1.EntityHuman.damageEntity(EntityHuman.java:801) ~[patched_1.15.2.jar:git-Paper-77]
at net.minecraft.server.v1_15_R1.EntityPlayer.damageEntity(EntityPlayer.java:742) ~[patched_1.15.2.jar:git-Paper-77]
at net.minecraft.server.v1_15_R1.Explosion.a(Explosion.java:187) ~[patched_1.15.2.jar:git-Paper-77]
at net.minecraft.server.v1_15_R1.World.createExplosion(World.java:1023) ~[patched_1.15.2.jar:git-Paper-77]
at net.minecraft.server.v1_15_R1.WorldServer.createExplosion(WorldServer.java:1539) ~[patched_1.15.2.jar:git-Paper-77]
at net.minecraft.server.v1_15_R1.World.createExplosion(World.java:1013) ~[patched_1.15.2.jar:git-Paper-77]
at net.minecraft.server.v1_15_R1.EntityTNTPrimed.explode(EntityTNTPrimed.java:113) ~[patched_1.15.2.jar:git-Paper-77]
at net.minecraft.server.v1_15_R1.EntityTNTPrimed.tick(EntityTNTPrimed.java:72) ~[patched_1.15.2.jar:git-Paper-77]
at net.minecraft.server.v1_15_R1.WorldServer.entityJoinedWorld(WorldServer.java:734) ~[patched_1.15.2.jar:git-Paper-77]
at net.minecraft.server.v1_15_R1.World.a(World.java:878) ~[patched_1.15.2.jar:git-Paper-77]
at net.minecraft.server.v1_15_R1.WorldServer.doTick(WorldServer.java:497) ~[patched_1.15.2.jar:git-Paper-77]
at net.minecraft.server.v1_15_R1.MinecraftServer.b(MinecraftServer.java:1245) ~[patched_1.15.2.jar:git-Paper-77]
at net.minecraft.server.v1_15_R1.DedicatedServer.b(DedicatedServer.java:423) ~[patched_1.15.2.jar:git-Paper-77]
at net.minecraft.server.v1_15_R1.MinecraftServer.a(MinecraftServer.java:1112) ~[patched_1.15.2.jar:git-Paper-77]
at net.minecraft.server.v1_15_R1.MinecraftServer.run(MinecraftServer.java:934) ~[patched_1.15.2.jar:git-Paper-77]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_212]

Mooshroom Cow give a Mushroom Stem instead a Beetroot Soup!

Mooshroom Cow give a Mushroom Stem instead a Beetroot Soup in the 1.16.1 version!

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update actions/checkout action to v2.7.0
• Update dependency org.apache.maven.plugins:maven-shade-plugin to v3.6.0
• Update actions/checkout action to v4
• Update actions/setup-java action to v4
• Update dependency org.bstats:bstats-bukkit to v3
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

github-actions

.github/workflows/maven.yml

• actions/checkout v2.3.4
• actions/setup-java v2

maven

pom.xml

• org.apache.maven.plugins:maven-shade-plugin 3.2.4
• org.spigotmc:spigot-api 1.16.5-R0.1-SNAPSHOT
• com.github.TheBusyBiscuit:Slimefun4 RC-27
• org.bstats:bstats-bukkit 2.2.1
• com.google.code.findbugs:jsr305 3.0.2

---

• Check this box to trigger a request for Renovate to run again on this repository

Mooshroom pet gives wrong item

Description (Required)

The mooshroom pet gives mushroom stems instead of mushroom stew.

Steps to reproduce the Issue (Required)

Put pet in inventory.

Expected behavior (Required)

Should be giving stew instead of stem.

Server Log / Error Report

No found errors.

Environment (Required)

• Minecraft Version:
• CS-CoreLib Version: n/a
• Slimefun Version: dev 867
• HotbarPets Version: dev 36

Action Required: Fix Renovate Configuration

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: undefined. Note: this is a nested preset so please contact the preset author if you are unable to fix it yourself.

Impose limits on hostile mobs outside of PVP regions

It would generally not be possible for players to attack each other outside of PVP on my server but we've found that the Hotbar Pets are afforded an exception and can attack and kill other players anywhere. (My mod was vaporized by someone's Hotbar creeper pet, for example). Can you impose limitations on these mobs that would cause them to adhere to worldguard limitations, treating them as "players' so to obey PVP restrictions?

Creeper Pets bypass protection

Description (Required)

Creeper pets explode islands and other things normally handled through the protection module of SF/Cs-corelib. I have a video of it below here.

Steps to reproduce the Issue (Required)

https://www.youtube.com/watch?v=q4GmmzizzzU

Expected behavior (Required)

It should not blow up blocks and the island should state the area is protected (it states it but the creeper pet bypasses it)

Server Log / Error Report

No errors are had in Console or SF Error reports.

Environment (Required)

https://screenshots.skizzles.me/wAnA3/meWUGAmO25.png

Patriot Pet does not give strength

Description (Required)

The patriot pet does not give strength when activated. It however takes the food and gives the other effects.

Steps to reproduce the Issue (Required)

youtube.com/watch?v=uxCZlQ8ylkA

Expected behavior (Required)

To give all the effects, including strength.

Server Log / Error Report

No Errors seen.

Environment (Required)

https://screenshots.skizzles.me/JIWA4/jAJAfeNE34.png

• Minecraft Version: 1.16.3
• CS-CoreLib Version: 90
• Slimefun Version: 677
• HotbarPets Version: 30

Pets no respect Region flags

Damaging pets do not respect the redprotect protection system flags.

Ghast pet bypasses other protection plugins

Description (Required)

Ghast Pet and Ender Dragon Pet(I know ender dragon's issue is reported already but it's there since May 2021 and it's February 2022 now) can deal damage in other protected areas (towns in this case).
video: https://streamable.com/mtvfzw

Steps to reproduce the Issue (Required)

Use ghast pet and ender dragon pet in protected areas and on other players

Expected behavior (Required)

To respect protections

Server Log / Error Report

no errors

Environment (Required)

• Minecraft Version: 1.18.1 pufferfish build 42
• CS-CoreLib Version: -
• Slimefun Version: dev 999
• HotbarPets Version: dev 38