thecodemonks/nytimes-app

🗽 A Simple Demonstration of the New York Times App 📱 using Jsoup web crawler with MVVM Architecture 🔥

nytimes-app's Issues

Add Theme Engine

Great work on the app! One change I was thinking about, was using a theme engine like Cyanea I've used it in a past app of mine and is easy to implement and I think would give NYTimes-App great character

App crashes when open in offline mode

Steps to reproduce

1. Go offline in the current device
2. Open Application

Expected behavior

App open with no internet message

Actual behavior

App crashes immediately

[Suggestion] introduce dependency injection

Hi @Spikeysanju you can introduce DI in this project
if you don't want to deal with Dagger, you can do manual DI using only Kotlin,
you can see my approach from below post
https://proandroiddev.com/hold-on-before-you-dagger-or-hilt-try-this-simple-di-f674c83ebeec

Share Icon not visible in Dark Mode

Added support for Ktlint on Github Actions

Suggestion

We can add Ktlint support and Format for housekeeping in the project, it will get for common lint errors and do code formatting on PR and Merge

Introduce View Binding instead of Kotlin synthetic binding (deprecated)

Refactor Code

Refactor Code on Network Connectivity & Add Base Fragment

Article List Flickering when tabs are changes

Bug

When ever we switch tabs the list first shows the previous data then flicker to a new list

Expected

on switch tabs no flickering should appear

Migrate from LiveData to Flow for Bookmarks

Support Light Mode & Dark Mode

Proposed Change

• Support for Light/Dark mode using Datastore
• This change is to encourage the participants of Hacktoberfest 2020 for the this events

Reference

Datastore - https://developer.android.com/topic/libraries/architecture/datastore

Writing Test Cases

@Spikeysanju Hi i will be cool to have test cases, can you create a mile store and we can estimate Testing in the project?

Add KTLint Style

Support No Internet Connection State

Proposed Change

• Support for No Internet Connection & Connection Back with animation using StateFlow
• This change is to encourage the participants of Hacktoberfest for the this events

Expected Behaviour

⚠️ Note - Fade in & fade out collapse needs to be done!

Reference

StateFlow - https://kotlin.github.io/kotlinx.coroutines/kotlinx-coroutines-core/kotlinx.coroutines.flow/-state-flow/

Add About Screen

Add an about menu to show the application name following data

• App Logo
• App Name
• App Version
• Visit - (Which takes to our NYTimes repo in Github)

Preview 👇

Add Empty State View

share article url

share article URL from article details page using ShareSheet
@Spikeysanju

Replace Application Component (Deprecated)

Replace Application Component(Deprecated) with Singleton Component

onActivityCreated (Deprecated)

Refactor Code

Add extension function to remove boilerplate code

[Crash] On tap on articles in Bookmark app crashes.

Steps to reproduce :

1. Add a bookmark
2. Navigate to bookmarks and tap on any article
3. App crashes.

Expected : App should navigate to article details.

Fix :
Bookmark seems to have wrong navigation path

newsAdapter.setOnItemClickListener { article ->
           ...
            findNavController().navigate(
                R.id.action_articlesFragment_to_articleDetailsFragment,
                bundle
            )
        }

It should be ,

newsAdapter.setOnItemClickListener { article ->
            val bundle = Bundle().apply {
                putSerializable("article", article)
            }
            findNavController().navigate(
                R.id.action_bookmarksFragment_to_articleDetailsFragment,
                bundle
            )
        }

Update dependencies

Introduce StateFlow instead of LiveData

Fix JDK version