thecodingmachine/mvc.splash

A MVC framework deeply integrated with Mouf

Welcome to the Splash MVC framework

What is Splash?

Splash is a MVC PHP framework. This package contains the glue code between Splash and the Mouf dependency injection framework.

Documentation

Check the documentation on the Splash website

mvc.splash's Issues

Missing PSR-4 support for Controller generator

When using PSR-4 in main composer, we get a warning message on "new controller" interface of Mouf : Warning! Splash could not detect the autoload section of your composer.json file. Unless you are developing your own autoload system, you should configure composer.json to define a source directory and a root namespace using PSR-0.

DaoFactory injection on creating new url

On creating a new url, since tdbm's new architecture (Dao/Generated), splash uses old DaoFactory's namespace (Dao/) and not the new (Dao/Generated)

Error with Doctrine file cache when debug = false

When debug=false in Mouf, there is an error occuring with the cache:

Fatal error: Uncaught Error: Call to undefined method Mouf\Mvc\Splash\Annotations\Get::__set_state()

Controller generation with empty redirect

Try to create a new controller, using the UI, and for the action, leave an empty "redirect" field.

You will get a buggy generated PHP file, with this:

    header("Location: <br />

( ! ) Notice: Undefined index: redirect in /home/david/projects/wabel/workspace.drupal/vendor/mouf/mouf/vendor/mouf/mvc.splash-common/src/Mouf/Mvc/Splash/Controllers/Admin/SplashCreateControllerController.php on line 358
Call Stack
#	Time	Memory	Function	Location
1	0.0000	240760	{main}( )	../mouf_router.php:0
2	0.0001	241832	require( '/home/david/projects/wabel/workspace.drupal/vendor/mouf/mouf/vendor/mouf/mvc.splash/src/splash.php' )	../mouf_router.php:13
3	0.0116	2104256	Mouf\Mvc\Splash\Splash->route( )	../splash.php:24
4	0.0903	2967712	call_user_func_array ( )	../Splash.php:258
5	0.0903	2968712	Mouf\Mvc\Splash\Controllers\Admin\SplashCreateControllerController->generate( )	../Splash.php:258

");

allow to customize .htaccess file

As .htaccess is generic and so often part of the committed files, it would be nice to allow adding custom rules / redirections ... as an example, add a "Force HTTPS" directive, or page redirects in case of site migration, ...

Error with CSRF_ALLOWED_DOMAIN_NAMES

During the installation process, the instance "TheCodingMachine\Middlewares\CsrfHeaderCheckMiddleware" is created before the config variable "CSRF_ALLOWED_DOMAIN_NAMES".
This result an error "Undefined constant .." in the Mouf status page

We must save this instance again (i.e. after the config variable "CSRF_ALLOWED_DOMAIN_NAMES" is set) to solve the error.

Mouf validators displays an error about splash before installation tasks

Mouf validators ask to create a splash instance if the installation task have not been running yet. This may be confusing, because the install task won't do anything if the splash instance already exists.

When using Splash create controller, the wrong package is called

See issue #2:

Have a look at the path of the file in error....

The controller of Mouf's Splash instead of the app's Splash!

HTTP Code 400 for Missing Parameters ?

If a parameter is not passed when calling an URL, an exception, "Missing Parameter", is thrown which returns a 500 HTTP error. I think that it would be preferable to return a 400 HTTP error "Bad request" because it is a client error, not a server one. Similarly, we can do the same thing for the malformed parameters.

Furthermore, I think that we should return a 405 HTTP error "Method Not Allowed" if the URL exists but not for the method used (GET, PUT, POST, ..).

Automatically purge controllers cache when a controller is created

When we create a controller via the Splash UI, it would be a great idea to purge the cache.

Specify custom 404 page

It sould be interesting to be able to specify our own custom 404 page whitout having to rewrite the controller.

We should add properties to the HttpErrorController (that implements Http404HandlerInterface, Http500HandlerInterface and Scopabel) to specify the path of our 404 view or even a HTMLElementInterface to be directly inegrated.

[Doc] The documentation about URL params miss some points

Hi,

I read the doc and I think some points are missing : you don't talk about the way to call parameters with the @url param like this :

@url /test/{var1}/{var2}

Plus, you don't talk about the @get and @post annotation too.

You should mention that we must flush "RED" cache in Mouf BO when we change URL in any controller in order that the change can be applied.

We can also say, with a screenshot for example, that we have a recap of all our URL in the Mouf backoffice, just to check if it is taken in account.

I think these points has to be explain to play well with url parameters in Splash ! :)

Good luck !

Add a support to auto-generate PHPUnit tests

When a controller is generated, it might be a good idea to autogenerate a PHPUnit class to test the controller.

Note: this would probably require to create a mouf/phpunit package that automatically sets up unit tests.

[Doc] : mising image in Settings and error handling

There is a missing image (splash default instance screenshot) in section "Settings and error handling"

Splash 7: add a "weak" mode

Splash 7 current behaviour is "strict": if some output is performed or nothing is returned from a controller, it triggers an error.

It could be good to weaken this behaviour in development (to get notices, warnings, etc...) or to ease migration (especially in the case of Mouf modules)