thejokersthief/banshee

Large-scale code change & PR lifecycle manager across a GitHub organisation

Permanently-Remote Service Reliability Engineer with a focus on the human side of engineering.

Connect with me:

Website | Twitter | LinkedIn

Latest Blog Posts:

• CI/CD Best Practises: Scaling A Delivery Platform
• 2022 Check-in: Professional Development
• The Importance Of A Golden Path
• 2021 Check-in: Professional Development
• The Incident Response Lifecycle

Featured Blog Posts:

banshee's Issues

[BUG] Errors out when running into submodule directory

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

Program errors with "is a directory" when it comes across a submodule's folder

Expected Behavior

Skip the directory

Steps To Reproduce

1. have a repo that has N folders with M files

2. add a submodule this will show as a directory in github ui with this icon
   

3. run banshee with a command configured (that shouldn't affect the directory)

4. see error in terminal like this:

══════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════

     adding error: read /<redacted>/tmp/repos.cache/<redacted>/<submodule_folder_name>: is a directory

══════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════

Anything else?

No response

Relevant log output

══════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════

     adding error: read /<redacted>/tmp/repos.cache/<redacted>/<submodule_folder_name>: is a directory

══════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════