themiked/add-seo-meta-tags

A refactoring of the add-meta-tags plugin

Hi there 👋

add-seo-meta-tags's Issues

Improper escaping

https://github.com/theMikeD/add-seo-meta-tags/blob/master/add-seo-meta-tags.php#L908 is escaped incorrectly. It results in the HTML link being output as an escaped string.

This should be properly escaped without breaking the HTML link in the get text call.

		// Show message if nothing is enabled, then bail
		if ( ! in_array( '1', $global_values, true ) ) {
			?>
			<p>
				<?php
				printf(
					// translators: %1$s is replaced with the opening <a> tag with the href set to the options panel, %2$s is the closing <a> tag
					esc_html__( 'No SEO fields were enabled. Please enable post fields in the %1$s Meta Tags options page %2$s', 'add-meta-tags' ),
					'<a href="' . esc_url( get_admin_url() . 'options-general.php?page=' . $this->slug ) . '">',
					'</a>'
				);
				?>
			</p>
			<?php
			return;
		}