[BUG] Loading textdomain fails

[themosis]

[BUG] Loading textdomain fails

[jlambe]

@Jaspervv I'm already working on a solution for this. I'm adding a load_themosis_plugin_textdomain function to handle correct .mo file loading.

[jlambe]

Thanks for reporting this one.

Regarding the plugin relative path, I suggest to add a method to the PluginManager class so we get simply do this:

load_plugin_textdomain(
    $plugin->getHeader('text_domain'),
    false,
    $plugin->getRelativePath())
);

And now regarding the helper function, can you describe where do you actually define it ? You seem to pass the plugin directoy as a parameter, using your function from a plugin root, the following snippet is supposed to work, right ?

<?php
// Plugin headers
// ....

loadThemosisPluginTextDomain($plugin->getDirectory());

[Jaspervv]

I made the function wrapper for this issue, we currently have the code without it being inside a function. (don't worry, I did test it 😋)

loadThemosisPluginTextDomain($plugin->getDirectory()); does indeed work, that would also be the best way to use it dynamically.

I made an issue instead of a pull request because I have no idea what a good place for the function would be.

[jlambe]

@Jaspervv I've currently developped an application textdomain function inside the Core/helpers.php called load_application_textdomain in order to set translations files on the application root. We could add your function there as well certainly so it is sure that it is available on all plugins and mu-plugins.

https://github.com/themosis/framework/blob/master/src/Core/helpers.php#L279