themotleyfool/wagtail-automatic-redirects

Package to help with Wagtail URL redirects

wagtail-automatic-redirects's Issues

Make use of `bulk_create` to avoid scaling issues

It was pointed out to me by Wagtail core developer @kaedroho that we should consider making use of Django's bulk_create to avoid scaling issues with the automatic redirects.

We are currently using create_or_update (here and here).

I was wondering if the update part of that method is ever needed. If we already have a redirect pointing from an old path to the page object then this should still point to the right page object, even it if its slug is changed again (or the page is moved). Please correct me if I am wrong. Might be worth adding a test to make sure this works.

In that case the redirect don't need updating, we could drop the update part and create only new redirects in an efficient manner.

Add tests for automatic redirect logic

Support Wagtail 3.0

Hey all,

Checking through the source, this package isn't able to be used with Wagtail^=3.0 currently. Are there any plans to update this?

Thanks - Will.

Move code from dubs repo into package

There is a PR in the Dubs repo to accomplish automatic redirects. We would like this code to be available to our other repos using Wagtail, and maybe even open source?

• Please move the code from the PR into this package.

The PagesAppConfig may need to be an Abstract class and then inherited by the individual Wagtail Apps that want to use it.

• Please also update README with instructions for using the class in Wagtail apps.

Update `SiteMiddleware` import for Wagtail 2.11 compat

The import location of SiteMiddleware was changed in the 2.11 release of Wagtail to wagtail.contrib.legacy. The import would need to be changed in this package or the use of SiteMiddleware would need to be removed to allow use/development of the package with later versions of Wagtail.

See also Wagtail 2.11 release notes

Leverage new page move hooks

Wagtail now has page move hooks that could be nice for adding redirects when moving a page that is already published.