Giter Site home page Giter Site logo

requisition's People

Contributors

fl0w avatar greenkeeperio-bot avatar jonathanong avatar vkhv avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

requisition's Issues

Bug: empty body is not handled correctly by `res.text()`

On this line, nothing will ever happen (i.e. no data or end events will be sent) if the content-length of the body is 0. Apparently we can detect this because res.readable === false in this case. So we should check that (meaning there's no body) and return an empty string (to maintain the text semantics) or null.

If you agree, I can PR.

Discussion: implement validateStatus like axios?

Hi! Have you thought about implementing something like validateStatus from axios?

https://github.com/mzabriskie/axios#request-config

  // `validateStatus` defines whether to resolve or reject the promise for a given
  // HTTP response status code. If `validateStatus` returns `true` (or is set to `null`
  // or `undefined`), the promise will be resolved; otherwise, the promise will be
  // rejected.
  validateStatus: function (status) {
    return status >= 200 && status < 300; // default
  },

I could maybe draft a PR if you think this fits the bill.

TODO:

General

  • 100% coverage
  • cookies
  • oauth signing
  • documentation
  • .extend() .defaults()
  • netrc

Refactor

  • use raw-body
  • use inflate

Request

  • compression
  • query(object)
  • send(body)
  • sendFile(filename)
  • type(type)
  • expectContinue().then( req => )
  • abort()
  • timeout(ms)
  • redirects(#)
  • retries(#)
    • custom retry backoff logic
  • auth()
  • agent()
  • ifModifiedSince(date)
  • ifNoneMatch(val)

Response

  • decompression
  • .charset
  • .etag
  • .lastModified
  • .pipe

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.